Closed Bug 946127 Opened 6 years ago Closed 6 years ago

Don't mark inline function as dllimport.

Categories

(Core :: MFBT, defect)

x86_64
Windows 7
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla28
Tracking Status
firefox28 --- fixed

People

(Reporter: jacek, Assigned: jacek)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

Attached patch patch.diffSplinter Review
This causes compile error on GCC (mingw).
Attachment #8342246 - Flags: review?(till)
Comment on attachment 8342246 [details] [diff] [review]
patch.diff

Review of attachment 8342246 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not an MFBT peer, and I don't know what MFBT_API does, so I can't review this. Forwarding to Waldo.
Attachment #8342246 - Flags: review?(till) → review?(jwalden+bmo)
Note that the LZ4 import was largely a refresh of Vlad's patch from bug 830881. So while it looks like I should be able to review this, I really can't, sorry.
Attachment #8342246 - Flags: review?(jwalden+bmo) → review+
https://hg.mozilla.org/mozilla-central/rev/06102544b4ca
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.