946170 - [Download API] Resuming a download is not working.

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: General, defect)

Description

[Borja Salguero [:borjasalguero]]

When the server does not offer the option of 'resuming', the API should 'restart' the download automatically or deliver an error, and exposing a 'restart' method.

Comment 1

[Borja Salguero [:borjasalguero]]

Fabrice, when testing the API I've discovered this issue, could you take a look? Thanks!!

Comment 2

[[:fabrice] Fabrice Desré]

Please cc Aus to any download bugs, as he's taking over the platform part.

Comment 3

[Borja Salguero [:borjasalguero]]

Hi Aus, 
When testing I've realized that this feature is broken, and we would need to have at least the basic functionality ready within our 1.3 goal. Could you help us on this? Thanks!

Comment 4

[Aus Lacroix [:aus]]

Yep, I'll take a look. The tests should have caught this...

Comment 5

[Aus Lacroix [:aus]]

Borja, could you re-test this please? This functions as expected for me. I've re-written the test for resuming and it passes as expected and the download does resume. One key thing to remember is that the Promise returned when calling resume() will only get called when the resumed download FINISHES. There is a status change event though that will show the download going from stopped to downloading. I'll be landing the new tests as part of this bug to ensure that everything keeps on working.

If this does not work for you, please let me know how you are testing it. Resuming typically requires http 1.1 and support for range requests. If those aren't available, resuming will fail and you'll need to restart the download yourself by finalizing the failed download object and creating a new one.

Comment 6

[Borja Salguero [:borjasalguero]]

This seems to be working now. Marking as WORKSFORME. Thanks!