946176 - [e.me][bug] Collections tapping issues

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Description

[Amir Nissim (:amirn)]

* After tapping the search field for the first time, subsequent taps only work when tapping the label

* same for Collections

Comment 1

[Amir Nissim (:amirn)]

From Peter's presentation:

"The search field is really hard to press, it often invokes a swipe instead. The system should disable swiping between panes when pressing on the search field."

"The first time after reboot, you can tap on icon and app label to launch a collection. After the first launch of a collection, tapping on the collection icon in the home screen does nothing. You can only launch the collection by tapping the app label."

Comment 2

[Ran Ben Aharon [:ranbena] EverythingMe]

Please disregard the first "The search field.." bug description.

Comment 3

[Ran Ben Aharon [:ranbena] EverythingMe]

Attachment: Patch - redirect to github PR

Comment 5

[Evyatar 'Tron' Amitay (everything.me)]

Comment on attachment 8343059 [details] [review]
Patch - redirect to github PR

simple fix, works like a charm.

Comment 6

[Jason Smith [:jsmith]]

How bad is the user impact here? Is this worth blocking on?

Comment 7

[Ran Ben Aharon [:ranbena] EverythingMe]

It's severe and started in Bug 925970.
The visual change raised the apps 30px upwards creating an overlap of elements.

It's a simple fix.

Comment 8

[Ran Ben Aharon [:ranbena] EverythingMe]

Amir, please merge this into master and 1.3 branch.

Comment 9

[Amir Nissim (:amirn)]

landed: https://github.com/mozilla-b2g/gaia/commit/3daa65c

Comment 10

[Amir Nissim (:amirn)]

landed in 1.3: https://github.com/mozilla-b2g/gaia/commit/352a1f0f9e6d6a33d6a2507d3c5d353d4343b742