Closed Bug 946377 Opened 11 years ago Closed 10 years ago

Array constructor/destructor mismatches in PeerConnectionImpl

Categories

(Core :: WebRTC: Signaling, defect)

Product:
Core
Component:
WebRTC: Signaling
Version:
Other Branch
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
RESOLVED DUPLICATE of bug 1055060

People

(Reporter: abr, Assigned: jib)

Details

In PeerConnectionImpl::GetLocalDescription(nsAString& aSDP) and PeerConnectionImpl::GetRemoteDescription(nsAString& aSDP), calls are made to to the char** variants, which return a block of memory allocated with an array allocator. However, when this block of memory is no longer needed, it is deallocated using delete rather than delete[]. In *most* cases, this won't cause any issues. It is, however, undefined in the language spec, and can cause real issues (cf. http://www.parashift.com/c++-faq/delete-array-built-ins.html)
(In reply to Byron Campen [:bwc] from comment #1) > It looks like this is fixed now? Yep. Bug 1055060.
Status: NEW → RESOLVED
Closed: 10 years ago
Flags: needinfo?(adam)
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.