Closed Bug 946564 Opened 7 years ago Closed 7 years ago

Make window._content chromeonly

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

(Keywords: dev-doc-complete, site-compat, Whiteboard: [qa-])

Attachments

(2 files)

The web shouldn't use it because no one else supports it, it's been deprecated since 2001 (though without any console messages), and it's already not supported via Xrays, so extensions ought not to break.

Can we just kill it, pretty please?
> so extensions ought not to break.

Except I guess they could be getting _content on the chrome window.  :(  And in fact, that's exactly what they do; it's all over the addons mxr.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
Actually, I'm going to try to make this chromeonly.  Lack of xray support means I don't have to add it to xpidl at all, and I can hack webidl enough to allow this.
Blocks: 864845
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Summary: Can we nix window._content ? → Make window._content chromeonly
Assignee: nobody → bzbarsky
Status: REOPENED → ASSIGNED
Also, I'd be happy to add a warning in this getter if people prefer.  But addons use it a _lot_.
Attachment #8342861 - Flags: review?(peterv) → review+
Comment on attachment 8342862 [details] [diff] [review]
part 2.  Make window._content chromeonly and define it in WebIDL.

Review of attachment 8342862 [details] [diff] [review]:
-----------------------------------------------------------------

I'd really like to add the warning :-/.
Attachment #8342862 - Flags: review?(peterv) → review+
https://hg.mozilla.org/mozilla-central/rev/2154019a866e
https://hg.mozilla.org/mozilla-central/rev/537ff932d5f1
Status: ASSIGNED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
I guess this is technically site-compat.
Keywords: site-compat
Keywords: dev-doc-needed
OS: Mac OS X → All
Hardware: x86 → All
Duplicate of this bug: 864845
Whiteboard: [qa-]
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.