946564 - Make window._content chromeonly

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

The web shouldn't use it because no one else supports it, it's been deprecated since 2001 (though without any console messages), and it's already not supported via Xrays, so extensions ought not to break.

Can we just kill it, pretty please?

Comment 1

[Boris Zbarsky [:bzbarsky]]

> so extensions ought not to break.

Except I guess they could be getting _content on the chrome window.  :(  And in fact, that's exactly what they do; it's all over the addons mxr.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Actually, I'm going to try to make this chromeonly.  Lack of xray support means I don't have to add it to xpidl at all, and I can hack webidl enough to allow this.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Allow installing chromeonly webidl quickstubs too.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Make window._content chromeonly and define it in WebIDL.

Comment 5

[Boris Zbarsky [:bzbarsky]]

Also, I'd be happy to add a warning in this getter if people prefer.  But addons use it a _lot_.

Comment 6

[Peter Van der Beken [:peterv]]

Comment on attachment 8342862 [details] [diff] [review]
part 2.  Make window._content chromeonly and define it in WebIDL.

Review of attachment 8342862 [details] [diff] [review]:
-----------------------------------------------------------------

I'd really like to add the warning :-/.

Comment 7

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/2154019a866e
https://hg.mozilla.org/integration/mozilla-inbound/rev/537ff932d5f1

I filed bug 948096 on adding a warning.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2154019a866e
https://hg.mozilla.org/mozilla-central/rev/537ff932d5f1

Comment 9

[Boris Zbarsky [:bzbarsky]]

I guess this is technically site-compat.

Comment 11

[Kohei Yoshino]

https://developer.mozilla.org/en-US/docs/Web/API/Window
https://developer.mozilla.org/en-US/Firefox/Releases/29/Site_Compatibility