946674 - Building emulator on darwin x86 leads to failure make: *** No rule to make target `out/host/darwin-x86/usr', needed by `"out/emulator.tar.gz"'. Stop.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Emulator, defect)

Description

[Pete Moore [:pmoore][:pete]]

Attachment: Log file of failed emulator build

In bug 930568, we are standing up emulator builds for darwin x86 to appear in tbpl with the other build artifacts. Currently we only make b2g emulator builds for linux in our continuous integration. This will allow people to test emulator builds on mac without having to build themselves, and also highlight when the emulator builds break on mac.

Log file of build failure attached.

The invoked targets of the build system are:
1) ./build.sh droid
2) ./build.sh package-emulator

Target 1 (droid) passes without issue.

Target 2 (package-emulator) fails with:

make: *** No rule to make target `out/host/darwin-x86/usr', needed by `"out/emulator.tar.gz"'.  Stop.

This failure occurs because the out/host/darwin-x86/usr directory is not created at an earlier step of the build process - this directory is missing from the file system.

These two makesfiles appear to be responsible for creating the content of the "usr" directory:

1) https://github.com/TaintDroid/android_platform_libcore/blob/9bc6320e7e198bf4789b083b59bcddc118147553/Android.mk#L55-L70
2) https://github.com/mozilla-b2g/platform_bionic/blob/e77d54d98a430a5f80d3bd5569f3b32866e4c538/libc/zoneinfo/Android.mk#L17-L26

From above we see that "usr" is only created if WITH_HOST_DALVIK is true.

However, the failing make invocation assumes the "usr" directory exists, regardless of the state of WITH_HOST_DALVIK:

https://github.com/mozilla-b2g/gonk-misc/blob/master/Android.mk#L333-L355

I believe this is what leads to the build failure. I suspect WITH_HOST_DALVIK is not set, so that "usr" directory is not created, and then gonk-misc module cannot package it.

I believe the build should function regardless of the state of WITH_HOST_DALVIK, so perhaps gonk-misc needs to consider the state of WITH_HOST_DALVIK before attempting to include "usr" directory. However, I am not intimate with the meaning of WITH_HOST_DALVIK and the necessity of whether the usr directory should be included, therefore I leave it to the experts to decide. :)

Many thanks,
Pete

Comment 1

[Michael Wu [:mwu]]

You should probably just remove $(HOST_OUT)/usr from the list of dependencies in gonk-misc/Android.mk . It's only potentially interesting for emulator-x86 builds, which we don't build on tbpl.

Comment 2

[Pete Moore [:pmoore][:pete]]

Attachment: bug946674_gonk-misc.patch

Many thanks Michael. Patch attached for review.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gonk-misc/commit/21f7bb53b6eb1a069e6ded19ca6cd90c80dd89af

Comment 4

[Pete Moore [:pmoore][:pete]]

Many thanks guys!