Closed Bug 946724 Opened 11 years ago Closed 11 years ago

[e.me] Collection suggestions for unsupported languages should show English suggestions

Categories

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Everything.me
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:1.3+, b2g-v1.3 fixed)

Status:
RESOLVED FIXED
Milestone:
1.3 C1/1.4 S1(20dec)
Project Flags:
blocking-b2g 1.3+
Tracking Flags:
Tracking Status
b2g-v1.3 --- fixed

People

(Reporter: amirn, Assigned: amirn)

References

Details

(Whiteboard: [systemsfe])

Attachments

(2 files, 1 obsolete file)

setup.patch
2.32 KB, text/x-patch
Details
Redirect to PR
46 bytes, text/x-github-pull-request
Details | Review 
      No description provided.
Assignee: nobody → amirn
Blocks: 938067
Regarding Bug 938067, we've come to an agreement that for unsupported territories, the suggestion list will appear in English. The hardcoded translations will be ignored.
Once a language is fully supported, the list will automatically appear translated for devices in that language.
Attached file Redirect to PR (obsolete) — 

        Attachment #8344316 -
        Flags: review?

    
  

        Attachment #8344316 -
        Flags: review? → review?(ran)

    
    

    
  

      
      
      
      

        Attached file
          
        setup.patch
        — 
      

    


  
simulates the server response and untranslated Collections

    
    

    
  
Comment on attachment 8344316 [details] [review]
Redirect to PR

Great work.

        Attachment #8344316 -
        Flags: review?(ran) → review+

    
    

    
  
Risk: low. Isolated to the Collection suggestion list. Minimal code changes.

* Notice that real users won't be affected by it as their territory is always supported by E.me servers
blocking-b2g: --- → 1.3?
blocking-b2g: 1.3? → 1.3+

    
    

    
  
Amir, please merge this into master and 1.3 branch.
Flags: needinfo?(amirn)
Whiteboard: [systemsfe]
Target Milestone: --- → 1.3 C1/1.4 S1(20dec)
Status: NEW → ASSIGNED

    
    

    
  
landed in master: https://github.com/mozilla-b2g/gaia/commit/1ea989a
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: needinfo?(amirn)
Resolution: --- → FIXED

    
    

    
  
reverted until server code lands
https://github.com/mozilla-b2g/gaia/commit/1afe3de31a8974d301c38bfb5aad4c87bead5319
Status: RESOLVED → REOPENED
Resolution: FIXED → ---

    
    

    
  

      
      
      
      

        Attached file
          
        Redirect to PR
        — 
      

    


  

        Attachment #8344316 -
        Attachment is obsolete: true

    
    

    
  
landed: https://github.com/mozilla-b2g/gaia/commit/baf9f72
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED

    
    

    
  
Uplifted baf9f72b71fb126999c6b455363f6a207b7c49bd to:
v1.3: 24679276cbf3c5e48a15e5f34bee07e3deb30db2

          status-b2g-v1.3:
          --- → fixed

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: