946742 - [Unagi_1.2][Pre-IOT] Message overlapped during multiparty when a call is released

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Description

[David Palomino [:dpalomino]]

Attachment: multi_party_label_3.png

Detected during pre-IOT for 1.2. 

Gecko: d77ba08
Gaia: 1b67b55

With a multiparty established, when one of the calls is released, the notification message "XXX has left the conference" in Spanish (i.e. "XXXX ha abandonado la llamada") is shown in two different lines, and the second line is overlapped with dialer panel. 

See attached screenshot. 

Nominated for koi, in case we could fix this.

Comment 1

[Preeti Raghunath(:Preeti)]

UX,

Please help to see if this is acceptable or not.

Comment 2

[Jason Smith [:jsmith]]

Blocking+ because this will cause l10n issues in target launch locales to understand what's read in the message provided.

Comment 3

[Preeti Raghunath(:Preeti)]

Please hep reassign as this will be a blocker.

Comment 4

[Jason Smith [:jsmith]]

(In reply to Preeti Raghunath(:Preeti) from comment #3)
> Please hep reassign as this will be a blocker.

Actually, we want etienne in this case, as he works on the dialer app.

Comment 5

[Etienne Segonzac (:etienne)]

The top part might be fixed by an uplift, the banner part needs a patch.
For both I think Rik will be the most efficient.

Comment 6

[Anthony Ricaud (:rik)]

Both actually need a patch.

Comment 7

[Anthony Ricaud (:rik)]

Attachment: https://github.com/mozilla-b2g/gaia/pull/14614

Removing the height property allows the box to scale with more text.
I also removed the pointer-events and z-index properties since they were not useful.

Comment 8

[Anthony Ricaud (:rik)]

FYI, when testing on master, I found bug 949542. This will be a separate fix since bug 949542 only affects 1.3 and newer.

Comment 9

[Anthony Ricaud (:rik)]

https://github.com/mozilla-b2g/gaia/commit/0ee9b91a5cf770c099ecaeaadf85fec9c493f53d

Comment 10

[John Ford [:jhford] CET/CEST Berlin Time]

Uplifted 0ee9b91a5cf770c099ecaeaadf85fec9c493f53d to:
v1.3: 035ecebb6449473f90907292896f1ebdbddf3bf0
v1.2: 4bb323a5cac974e05963e77bd38abd99497205e8