Closed Bug 949542 Opened 11 years ago Closed 11 years ago

Status messages are a bit too high

Categories

(Firefox OS Graveyard :: Gaia::Dialer, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Dialer
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(b2g-v1.3 fixed)

Status:
RESOLVED FIXED
Tracking Flags:
Tracking Status
b2g-v1.3 --- fixed

People

(Reporter: rik, Assigned: rik)

References

Details

Attachments

(2 files)

Wrongly positioned status
165.25 KB, image/png
Details
https://github.com/mozilla-b2g/gaia/pull/14617
46 bytes, text/x-github-pull-request
etienne
: review+
fabrice
: approval-gaia-v1.3+
Details | Review
When we've redimensionned the call options in bug 923059, we forgot to move those status messages down a bit.
Asking 1.3+ since bug 923059 ships in 1.3.
blocking-b2g: --- → 1.3?
Attachment #8346644 - Flags: review?(etienne)
Attachment #8346644 - Flags: review?(etienne) → review+
https://github.com/mozilla-b2g/gaia/commit/344bebd8d611a3a5d330b041f78e587c154026e9
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
triage: should not block release. to land in 1.3, pleaes ask for approval
blocking-b2g: 1.3? → ---
Comment on attachment 8346644 [details] [review] https://github.com/mozilla-b2g/gaia/pull/14617 [Approval Request Comment] [Bug caused by] (feature/regressing bug #): bug 923059 [User impact] if declined: Ugly notifications when someone leaves a call [Testing completed]: Landed on master for a 3-4 days [Risk to taking this patch] (and alternatives if risky): one line patch, no risk. Easy to back out. [String changes made]: none
Attachment #8346644 - Flags: approval-gaia-v1.3?
Attachment #8346644 - Flags: approval-gaia-v1.3? → approval-gaia-v1.3?(fabrice)
Attachment #8346644 - Flags: approval-gaia-v1.3?(fabrice) → approval-gaia-v1.3+
Uplifted to v1.3: a8798f4c5f8f2a7b9b395f7f314e49d5f66e248b
status-b2g-v1.3: --- → fixed
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: