[Rocketbar] Implement preference for search results origin/entrypoint

RESOLVED FIXED in 1.3 C1/1.4 S1(20dec)

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: kgrandon, Assigned: kgrandon)

Tracking

unspecified
1.3 C1/1.4 S1(20dec)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [c= p=3 s=2013.12.20 u=])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
We should implement preferences (possibly 2) for the search results origin and entry point. This would give us the ability to swap the results app out and test multiple versions quickly.
This sounds like a cool idea. It would be nice to be able to switch it from being the homescreen app and a separate search app for example. That would make it possible to switch the search app but not the homescreen app and vice versa.
Could we use a similar mechanism to the homescreen app setting so that end users could eventually install an alternative search app and set it as their search app in settings?
(Assignee)

Comment 3

5 years ago
(In reply to Ben Francis [:benfrancis] from comment #2)
> Could we use a similar mechanism to the homescreen app setting so that end
> users could eventually install an alternative search app and set it as their
> search app in settings?

Having this done would potentially allow for that in the future, but this is not the immediate goal. The immediate goal is to work closely with E.me to provide the best possible single search app. Our architecture will certainly be flexible enough to allow for any future decisions by product to be taken into account though.
Friendly note: don't use entry points for that. They are going to be deprecated very soon.
I'm not sure but I don't think Kevin literally meant an entry point in the app manifest. Just the URL which the src of the mozapp iframe is set to when it is created in the search code https://github.com/mozilla-b2g/gaia/pull/14380/files#diff-5699b1000bc807368718bfddf7ef58c3R48

It's currently hard coded as app://homescreen.gaiamobile.org/search/index.html (which probably won't work for DEBUG profiles btw).

The code probably also needs modifying to better handle the case where multiple apps offer to receive search messages. Currently we just get a list of them and arbitrarily pick the last one in the list https://github.com/mozilla-b2g/gaia/pull/14380/files#diff-5699b1000bc807368718bfddf7ef58c3R73

We could instead filter by the manifest URL (not origin) set in this preference.
(Assignee)

Updated

5 years ago
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Whiteboard: [c= p=3 s= u=]
(Assignee)

Comment 6

5 years ago
Created attachment 8346182 [details] [review]
Github pull request

Quick implementation to swap out the search app for rapid testing. Does not yet filter out port selection via origin yet, but should be good enough for testing stuff now.
Attachment #8346182 - Flags: review?(21)
(Assignee)

Comment 8

5 years ago
Resolving bugs which have landed in the rocketbar branch to clean up the dependency tree. All commits in the branch have been reviewed, and we can merge it into master at any point.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
Whiteboard: [c= p=3 s= u=] → [c= p=3 s=2013.12.20 u=]

Updated

5 years ago
Target Milestone: --- → 1.3 C1/1.4 S1(20dec)
You need to log in before you can comment on or make changes to this bug.