Closed
Bug 946904
Opened 11 years ago
Closed 11 years ago
[Rocketbar] Inter-app communication ports disconnect
Categories
(Firefox OS Graveyard :: Gaia, defect)
Tracking
(Not tracked)
RESOLVED
WORKSFORME
1.3 C1/1.4 S1(20dec)
People
(Reporter: kgrandon, Assigned: kgrandon)
References
Details
(Whiteboard: [c= p=2 s= u=])
Attachments
(1 file)
For some reason the system <-> search results communication channel seems to be breaking when the rocketbar is closed. Need to figure out why.
| Assignee | ||
Updated•11 years ago
|
Summary: [Rocketbar] Inter-app communication channel seems to disconnect → [Rocketbar] Inter-app communication ports disconnect
| Assignee | ||
Updated•11 years ago
|
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
Whiteboard: [c= p=2 s= u=]
| Assignee | ||
Comment 1•11 years ago
|
||
Hi Vivien,
For some reason the port gets disconnected when we call setVisible(false) on the iframe. I'm not sure if this is a bug, but the workaround seems to be to make sure we revive the port when we need to use it.
Attachment #8343492 -
Flags: review?(21)
Comment 2•11 years ago
|
||
Comment on attachment 8343492 [details] [review]
Github pull request
I'm worried that we will open a port for each message. Let me now if I was wrong, this API is pretty new to me :)
Attachment #8343492 -
Flags: review?(21)
| Assignee | ||
Comment 3•11 years ago
|
||
Comment on attachment 8343492 [details] [review]
Github pull request
Hi Vivien,
I made an update which closes the existing port if it exists before opening a new one. Let me know what you think.
Attachment #8343492 -
Flags: review?(21)
Comment 4•11 years ago
|
||
Comment on attachment 8343492 [details] [review]
Github pull request
Can we try to understand why the communication channel is broken ? It seems very weird since one of the main use case of this API is to communicate between 2 or more apps and many of them could not be visible. I would like to figure out what is the root of the issue here.
Attachment #8343492 -
Flags: review?(21)
| Assignee | ||
Comment 5•11 years ago
|
||
This appears to be fixed in latest builds - not sure what was happening here.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → WORKSFORME
Comment 6•11 years ago
|
||
Kevin, were you testing with a build that wasn't including the fix for bug 928389 ?
| Assignee | ||
Comment 7•11 years ago
|
||
(In reply to Fernando Jiménez Moreno [:ferjm] (use needinfo instead of CC, please) from comment #6)
> Kevin, were you testing with a build that wasn't including the fix for bug
> 928389 ?
It looks like this landed on 12/03, so that's very likely. Thank you for letting me know!
Updated•11 years ago
|
Target Milestone: --- → 1.3 C1/1.4 S1(20dec)
You need to log in
before you can comment on or make changes to this bug.
Description
•