Closed
Bug 947107
Opened 11 years ago
Closed 11 years ago
[Gallery] Update gallery to use new 1.3 tool bar and tab bars
Categories
(Firefox OS Graveyard :: Gaia::Gallery, defect)
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 952445
People
(Reporter: epang, Assigned: pivanov)
References
Details
(Whiteboard: ux-tracking, visual design, visual-tracking, bokken)
Attachments
(3 files)
Update the gallery app to the new 1.3 tool bar designs. Update the gallery image edit screen to the new 1.3 tab bar designs.
Assignee | ||
Comment 1•11 years ago
|
||
Assignee | ||
Updated•11 years ago
|
Attachment #8343611 -
Flags: review?(dale)
Comment 2•11 years ago
|
||
Comment on attachment 8343611 [details] [review] patch for Gaia/master Needs rebased, also I am clearing review and setting it do David, Happy to test changes however this is a significant change so really should have him look at it, cheers
Attachment #8343611 -
Flags: review?(dale) → review?(dflanagan)
Assignee | ||
Comment 3•11 years ago
|
||
rebased :)
Comment 4•11 years ago
|
||
Comment on attachment 8343611 [details] [review] patch for Gaia/master This patch doesn't seem to work at all: - There are no icons in the toolbars - swiping side to side does not move from one image to the next Also, from looking at the code, I'm concerned that the CSS changes are using a tab list for things that are toolbars. I've commented about this on github: what does it mean to have a "selected" class for the camera button and the delete button? The new tab bar building block will be great for edit mode. But for the other parts of the app, don't we want an ordinary toolbar instead? Also, this patch incorrectly resolves merge conflicts with bugs 932919 (which removed the border editing option) and 945355 (which modified open.css). apps/gallery/style/images/actionicon_gallery_edit_enhance.png does not match apps/gallery/style/images/actionicon_gallery_edit_enhance@1.5x.png There is no 1.5x version of apps/gallery/style/images/actionicon_gallery_edit_enhance_on.png The patch removes apps/gallery/style/images/actionicon_gallery_edit_exposure_30x30.png (and its related sizes), but does not replace them with anything. The patch adds icons for apps/gallery/style/images/actionicon_gallery_edit_rotate.png, but that feature has not landed yet. This may be okay, however. The patch changes apps/gallery/style/images/iconaction_camera_gridview_30x30.png even though that icon is now unused (I think).
Attachment #8343611 -
Flags: review?(dflanagan) → review-
Comment 5•11 years ago
|
||
Also note that I'm about to land bug 925216 which adds an "i" icon between the share and trash icons to display info about each photo. So you'll need to rebase the patch for that as well.
Comment 6•11 years ago
|
||
Sorry David, should have mentioned, its dependent on https://bugzilla.mozilla.org/show_bug.cgi?id=947093 I also got confused first time I tried to review for the browser
Assignee | ||
Comment 7•11 years ago
|
||
rebased :) Thanks David Hey Eric, we miss these icons: 1. apps/gallery/style/images/actionicon_gallery_edit_enhance.png does not match apps/gallery/style/images/actionicon_gallery_edit_enhance@1.5x.png 2.There is no 1.5x version of apps/gallery/style/images/actionicon_gallery_edit_enhance_on.png
Reporter | ||
Comment 8•11 years ago
|
||
Hi Pavel, I've attached the two missing images. Thanks!
Assignee | ||
Comment 9•11 years ago
|
||
Thanks :) PR is updated
Assignee | ||
Updated•11 years ago
|
Attachment #8343611 -
Flags: review- → review?(dflanagan)
Comment 10•11 years ago
|
||
Comment on attachment 8343611 [details] [review] patch for Gaia/master r- because there are merge conflicts again. I suspect this time that it was the 2-column layout for flatfish that has messed this up. But I can't apply the patch to test it out, so I can't review.
Attachment #8343611 -
Flags: review?(dflanagan) → review-
Reporter | ||
Updated•11 years ago
|
Whiteboard: ux-tracking, visual design, visual-tracking, jian → ux-tracking, visual design, visual-tracking, bokken
Reporter | ||
Comment 11•11 years ago
|
||
marked as duplicate of 952445
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•