952445 - [Gallery] Update toolbars to use building blocks

Status: RESOLVED INVALID

(Firefox OS Graveyard :: Gaia::Gallery, defect)

Description

[Eric Pang [:epang] UX]

Once bug 947093 lands we should use the building blocks to update the toolbar in gallery.  Thanks!

Comment 2

[Eric Pang [:epang] UX]

Hi Hema, just wanted to know if there's any update on thsi bug.  Is Diego able to work on this? Thanks!

Comment 3

[Hema Koka [:hema]]

Folks who work on camera/gallery typically are pulled into madai camera work. We are looking into other stability issues that takes precedence over vis dev changes. It is not likely that we will be able to get this into 1.4 (also adding sri since this is the outcome of our discussions from a week back). We can certainly revisit when we are done with other bugs.

Thanks
Hema

Comment 4

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Hey Hema,
just wanted to know if there's any update on thsi bug?

Comment 5

[Hema Koka [:hema]]

No we have not been working on this -- have way too many high priority features for madai and blocking bugs for tarako/1.4 on our plate at the moment. Given that we are buried, it is not likely to make it into 1.4 as I mentioned in my previous comment too. 

Thanks
Hema

Comment 6

[Hema Koka [:hema]]

Wilson, can you take this up for 2.0 (note, if you have any 1.3T/1.4 blockers, those come before this). Sync with Diego -- he worked on some changes as part of another feature for gallery which did not make it to master

Thanks
Hema

Comment 7

[Jason Smith [:jsmith]]

This shouldn't block - this is a feature, which is something we won't block on unless we're past FL & we're planning to still land the feature.

Comment 8

[Wilson Page [:wilsonpage]]

hema: Yeah sure. I've not worked on Gallery as of yet, but can give it a shot.

Comment 9

[Wilson Page [:wilsonpage]]

Attachment: WIP (master)

Comment 10

[Wilson Page [:wilsonpage]]

Attachment: pull-request (master)

Comment 11

[Wilson Page [:wilsonpage]]

I haven't yet applied the new <gaia-header> to the Gallery's tablet layout as I have no tablet devices to test this on. These are still old building-block <header> elements. Can we still land this without updated tablet styles?

Comment 12

[Kevin Grandon :kgrandon]

Comment on attachment 8430783 [details] [review]
pull-request (master)

Super busy right now so I did not try this on a device, but the code generally looks fine to me. Nice job!

Comment 13

[Stephany Wilkes]

Thanks for the hard work on this. Can't wait to see it land!

Comment 14

[Wilson Page [:wilsonpage]]

Apologies, I didn't realise that this issue was referring to the black toolbar at the bottom of the viewport, not the grey header toolbar at the top. I'm created bug 1019468 to make <gaia-toolbar> so that we can implement these two web-component-building-blocks into Gallery at the same time.

Comment 15

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Wilson, I guess you should move patch to a new bug :)

Comment 16

[Stephany Wilkes]

Yes: we still want the gallery toolbar in existing building blocks for 2.0.

Flagging Amy to attach the visual specs for Gallery toolbar, which should also help to clarify the icons issue: example icons are aligned right/left but our new camera icons are centralized, and Wilson needs to know what to implement.

Comment 17

[Hema Koka [:hema]]

(In reply to Stephany Wilkes from comment #16)
> Yes: we still want the gallery toolbar in existing building blocks for 2.0.
> 
> Flagging Amy to attach the visual specs for Gallery toolbar, which should
> also help to clarify the icons issue: example icons are aligned right/left
> but our new camera icons are centralized, and Wilson needs to know what to
> implement.

Amy, can we please get this in today 6/3, so Wilson can work on it tomorrow (GMT)

Thanks
Hema

Comment 18

[Stephany Wilkes]

Yes - this is urgent. This won't land in time for FC if Wilson can't work on this today and tomorrow.

Comment 19

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Comment on attachment 8430783 [details] [review]
pull-request (master)

r- as this bug is not doing what described.
We should also wait for 2.1 to start landing gaia-header component not to compromise the Building block header centering work.

Comment 20

[Wilson Page [:wilsonpage]]

Comment on attachment 8430783 [details] [review]
pull-request (master)

Moved PR to bug 1019841

Comment 21

[Amy Lee [:amylee] UX]

(In reply to Stephany Wilkes from comment #16)
> Yes: we still want the gallery toolbar in existing building blocks for 2.0.
> 
> Flagging Amy to attach the visual specs for Gallery toolbar, which should
> also help to clarify the icons issue: example icons are aligned right/left
> but our new camera icons are centralized, and Wilson needs to know what to
> implement.

The building blocks are out of date. The new building block rules will be having the icons evenly spaced out on the toolbar (which looks like it's already doing now). I would close this bug as obsolete. Thanks!

Comment 22

[Wilson Page [:wilsonpage]]

We'll create a new bug for this once the new building-blocks come along then,

Comment 23

[Tiffanie Shakespeare [:tif]]

FYI filed bug for the fuzzy icons though - Bug 1020010