Closed Bug 952445 Opened 11 years ago Closed 10 years ago

[Gallery] Update toolbars to use building blocks

Categories

(Firefox OS Graveyard :: Gaia::Gallery, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Gallery
Platform:
x86
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(tracking-b2g:backlog)

Status:
RESOLVED INVALID
Milestone:
2.0 S3 (6june)
Project Flags:
tracking-b2g backlog

People

(Reporter: epang, Assigned: wilsonpage)

References

Details

(Whiteboard: visual-refresh)

Attachments

(2 obsolete files)

Once bug 947093 lands we should use the building blocks to update the toolbar in gallery. Thanks!
Assignee: nobody → dmarcos
blocking-b2g: --- → 1.4?
Hi Hema, just wanted to know if there's any update on thsi bug. Is Diego able to work on this? Thanks!
Blocks: 947087
Flags: needinfo?(hkoka)
Folks who work on camera/gallery typically are pulled into madai camera work. We are looking into other stability issues that takes precedence over vis dev changes. It is not likely that we will be able to get this into 1.4 (also adding sri since this is the outcome of our discussions from a week back). We can certainly revisit when we are done with other bugs. Thanks Hema
Flags: needinfo?(hkoka)
blocking-b2g: 1.4? → ---
Hey Hema, just wanted to know if there's any update on thsi bug?
Flags: needinfo?(hkoka)
No we have not been working on this -- have way too many high priority features for madai and blocking bugs for tarako/1.4 on our plate at the moment. Given that we are buried, it is not likely to make it into 1.4 as I mentioned in my previous comment too. Thanks Hema
Flags: needinfo?(hkoka)
Whiteboard: visual design, visual-tracking, bokken → visual-refresh
blocking-b2g: --- → 2.0?
Wilson, can you take this up for 2.0 (note, if you have any 1.3T/1.4 blockers, those come before this). Sync with Diego -- he worked on some changes as part of another feature for gallery which did not make it to master Thanks Hema
blocking-b2g: 2.0? → 2.0+
Flags: needinfo?(wilsonpage)
This shouldn't block - this is a feature, which is something we won't block on unless we're past FL & we're planning to still land the feature.
blocking-b2g: 2.0+ → backlog
hema: Yeah sure. I've not worked on Gallery as of yet, but can give it a shot.
Flags: needinfo?(wilsonpage)
Target Milestone: --- → 2.0 S2 (23may)
Assignee: dmarcos → wilsonpage
Attached file WIP (master) (obsolete) —
Depends on: 1007743
Target Milestone: 2.0 S2 (23may) → 2.0 S3 (6june)
Attached file pull-request (master) (obsolete) —
Attachment #8419536 - Attachment is obsolete: true
Attachment #8430783 - Flags: review?(kgrandon)
Attachment #8430783 - Flags: review?(arnau)
I haven't yet applied the new <gaia-header> to the Gallery's tablet layout as I have no tablet devices to test this on. These are still old building-block <header> elements. Can we still land this without updated tablet styles?
Comment on attachment 8430783 [details] [review] pull-request (master) Super busy right now so I did not try this on a device, but the code generally looks fine to me. Nice job!
Attachment #8430783 - Flags: review?(kgrandon) → review+
Thanks for the hard work on this. Can't wait to see it land!
Depends on: 1019468
Apologies, I didn't realise that this issue was referring to the black toolbar at the bottom of the viewport, not the grey header toolbar at the top. I'm created bug 1019468 to make <gaia-toolbar> so that we can implement these two web-component-building-blocks into Gallery at the same time.
Wilson, I guess you should move patch to a new bug :)
Yes: we still want the gallery toolbar in existing building blocks for 2.0. Flagging Amy to attach the visual specs for Gallery toolbar, which should also help to clarify the icons issue: example icons are aligned right/left but our new camera icons are centralized, and Wilson needs to know what to implement.
Flags: needinfo?(amlee)
(In reply to Stephany Wilkes from comment #16) > Yes: we still want the gallery toolbar in existing building blocks for 2.0. > > Flagging Amy to attach the visual specs for Gallery toolbar, which should > also help to clarify the icons issue: example icons are aligned right/left > but our new camera icons are centralized, and Wilson needs to know what to > implement. Amy, can we please get this in today 6/3, so Wilson can work on it tomorrow (GMT) Thanks Hema
Yes - this is urgent. This won't land in time for FC if Wilson can't work on this today and tomorrow.
Comment on attachment 8430783 [details] [review] pull-request (master) r- as this bug is not doing what described. We should also wait for 2.1 to start landing gaia-header component not to compromise the Building block header centering work.
Attachment #8430783 - Flags: review?(arnau) → review-
No longer blocks: gaia-header
Comment on attachment 8430783 [details] [review] pull-request (master) Moved PR to bug 1019841
Attachment #8430783 - Attachment is obsolete: true
(In reply to Stephany Wilkes from comment #16) > Yes: we still want the gallery toolbar in existing building blocks for 2.0. > > Flagging Amy to attach the visual specs for Gallery toolbar, which should > also help to clarify the icons issue: example icons are aligned right/left > but our new camera icons are centralized, and Wilson needs to know what to > implement. The building blocks are out of date. The new building block rules will be having the icons evenly spaced out on the toolbar (which looks like it's already doing now). I would close this bug as obsolete. Thanks!
Flags: needinfo?(amlee)
We'll create a new bug for this once the new building-blocks come along then,
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → INVALID
FYI filed bug for the fuzzy icons though - Bug 1020010
blocking-b2g: backlog → ---
tracking-b2g: --- → backlog
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: