Closed Bug 947142 Opened 6 years ago Closed 6 years ago
[DSDS][Message] Message Report show SIM information
As a user I want to know which SIM and phone number the message was sent on in the message report Acceptance Criteria; AC1: For SIM options I want to see SIM1 or SIM2 AC2: For phone number I want to see the phone number of the correct Dual SIM and if this can not be obtained I want to see "unknown"
Summary: [DSDS] Message Report show SIM information → [DSDS][Message] Message Report show SIM information
UX ref, page 9, 10 Ayman, are the texts final in this spec or do you need some proofreading from Tyler?
(In reply to Julien Wajsberg [:julienw] from comment #1) > Created attachment 8368588 [details] > FFOS_MessagesAppCommsApp_DSDS_V1.4_20140128_V3.0.pdf > > UX ref, page 9, 10 > > Ayman, are the texts final in this spec or do you need some proofreading > from Tyler? Final, unless there is any objection
Great, then this is an workable bug !
features should not block release, remove blocking flag
blocking-b2g: 1.4+ → ---
Hi julien, this patch add addtional information related to SIM by considering message iccId, and any feedback is welcome!
Comment on attachment 8381287 [details] [review] Link to github I didn't try on the device (too late right now ;) ) but this looks good, although we should use the new functions from bug 947139, and probably put more in Settings. Can you cherry-pick the commit(s) from bug 947139 so that you can move forward?
Here is a recipe for the cherry-pick: git remote add julien email@example.com:julienw/gaia.git git fetch julien git cherry-pick julien/947180-notification-dsds-without-promise^ julien/947180-notification-dsds-without-promise git rebase -i master The last command will allow you to reorder the commits and put the cherry-picked commits first. It also assumes your branch has "master" as base. It should be the closest ancestor that is on master, but I think you know this already :) Then when Bug 947139 will land, you just need to "git rebase -i master" (with an updated master) and remove the 2 lines for these commits.
Comment on attachment 8381287 [details] [review] Link to github Follow up fixing based on bug 947180, I will rebase again once it landed.
Comment on attachment 8381287 [details] [review] Link to github This looks very good (I only asked for 2 nits) but my fugu always crashes for 3 hours so I can't try :(
Comment on attachment 8381287 [details] [review] Link to github r=me with the nits I added on the commit in https://github.com/steveck-chung/gaia/commit/7ce7c141611e45bd5b8e2c6f780eeaf1c8864b2d
Attachment #8381287 - Flags: review?(felash) → review+
Thanks for the comments and fixed/landed in master: 0a1c74c1a17480b9c52bf54322d5997f8f103583 I also created a follow up bug 978705 for showing te SIM's carrier/number information when message's target SIM is not in the device.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Flags: in-moztrap?(pyang) → in-moztrap+
Verified by P1 test cases
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.