947142 - [DSDS][Message] Message Report show SIM information

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect, P1)

Description

[Wilfred Mathanaraj [:WDM]]

As a user I want to know which SIM and phone number the message was sent on in the message report

Acceptance Criteria;

AC1: For SIM options I want to see SIM1 or SIM2
AC2: For phone number I want to see the phone number of the correct Dual SIM and if this can not be obtained I want to see "unknown"

Comment 1

[Julien Wajsberg [:julienw]]

Attachment: FFOS_MessagesAppCommsApp_DSDS_V1.4_20140128_V3.0.pdf

UX ref, page 9, 10

Ayman, are the texts final in this spec or do you need some proofreading from Tyler?

Comment 2

[ayman maat :maat]

(In reply to Julien Wajsberg [:julienw] from comment #1)
> Created attachment 8368588 [details]
> FFOS_MessagesAppCommsApp_DSDS_V1.4_20140128_V3.0.pdf
> 
> UX ref, page 9, 10
> 
> Ayman, are the texts final in this spec or do you need some proofreading
> from Tyler?

Final, unless there is any objection

Comment 3

[Julien Wajsberg [:julienw]]

Great, then this is an workable bug !

Comment 4

[Joe Cheng [:jcheng] (please needinfo)]

features should not block release, remove blocking flag

Comment 5

[Steve Chung [:steveck]]

Attachment: Link to github

Hi julien, this patch add addtional information related to SIM by considering message iccId, and any feedback is welcome!

Comment 6

[Julien Wajsberg [:julienw]]

Comment on attachment 8381287 [details] [review]
Link to github

I didn't try on the device (too late right now ;) ) but this looks good, although we should use the new functions from bug 947139, and probably put more in Settings. Can you cherry-pick the commit(s) from bug 947139 so that you can move forward?

Comment 7

[Julien Wajsberg [:julienw]]

Here is a recipe for the cherry-pick:

  git remote add julien [e-mail]:julienw/gaia.git
  git fetch julien
  git cherry-pick julien/947180-notification-dsds-without-promise^ julien/947180-notification-dsds-without-promise
  git rebase -i master

The last command will allow you to reorder the commits and put the cherry-picked commits first. It also assumes your branch has "master" as base. It should be the closest ancestor that is on master, but I think you know this already :)

Then when Bug 947139 will land, you just need to "git rebase -i master" (with an updated master) and remove the 2 lines for these commits.

Comment 8

[Steve Chung [:steveck]]

Comment on attachment 8381287 [details] [review]
Link to github

Follow up fixing based on bug 947180, I will rebase again once it landed.

Comment 9

[Julien Wajsberg [:julienw]]

Comment on attachment 8381287 [details] [review]
Link to github

This looks very good (I only asked for 2 nits) but my fugu always crashes for 3 hours so I can't try :(

Comment 10

[Julien Wajsberg [:julienw]]

Comment on attachment 8381287 [details] [review]
Link to github

r=me with the nits I added on the commit in https://github.com/steveck-chung/gaia/commit/7ce7c141611e45bd5b8e2c6f780eeaf1c8864b2d

Comment 11

[Steve Chung [:steveck]]

Thanks for the comments and fixed/landed in master:
0a1c74c1a17480b9c52bf54322d5997f8f103583

I also created a follow up bug 978705 for showing te SIM's carrier/number information when message's target SIM is not in the device.

Comment 12

[Paul Yang [:pyang] (away)]

https://moztrap.mozilla.org/manage/cases/?pagenumber=1&pagesize=20&sortfield=created_on&sortdirection=desc&filter-tag=2577&filter-productversion=164
in-moztrap+

Comment 13

[Paul Yang [:pyang] (away)]

Verified by P1 test cases