947146 - Taps send a mouse move at the last position of the mouse

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: Input, defect, P2)

Description

[Jim Mathies [:jimm]]

str:

1) surf to techmeme.com, which has "hot areas" around each article snippet
2) bring up the nav bar edit
3) tap in the navbbar edit to invoke selection

result: you'll notice the underlying content react to the taps

Comment 1

[Jim Mathies [:jimm]]

str:

1) surf to techmeme.com, which has "hot areas" around each article link
2) move the mouse over one of the highlight areas
3) tap on content to remove the mouse cursor / highlight
2) bring up the nav bar edit
3) tap in the navbbar edit

Comment 2

[Jim Mathies [:jimm]]

Attachment: fix plus tests v.1

Comment 4

[Jim Mathies [:jimm]]

Comment on attachment 8345493 [details] [diff] [review]
fix plus tests v.1

Fixing this for good and adding some tests. (Note the tests rely on native events from bug 941774.)

Comment 5

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/828bbb5114bb

Comment 6

[Jim Mathies [:jimm]]

Comment on attachment 8345493 [details] [diff] [review]
fix plus tests v.1

[Approval Request Comment]
Bug caused by (feature/regressing bug #): This bug.
User impact if declined: Wonky working menu highlight color.
Testing completed (on m-c, etc.): Yes.
Risk to taking this patch (and alternatives if risky): Very low.
String or IDL/UUID changes made by this patch: None.

Comment 7

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/2ebab851cb33

Comment 8

[Kamil Jozwiak [:kjozwiak]]

Went through the following issue for iteration #21 without any problems. Used the following builds:
- http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014-01-14-00-40-02-mozilla-aurora/
- http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2014-01-14-03-02-36-mozilla-central/

Before testing to see if the issue has been fixed, reproduced the problem following comment #0 & comment #1 using the following build:
- http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2013-12-14-03-02-04-mozilla-central/

- Went through the original test cases from both comment #0 and comment #1 without any issues
- Ensured that sliding the Navigation App Bar from the Top/Bottom didn't invoke a mouse move (didn't re-highlight the link)
- Ensured that taping the URL under the Navigation App Bar didn't invoke a mouse move (didn't re-highlight the link)
- Ensured that sliding in the Windows Charm didn't invoke a mouse move (didn't re-highlight the link)
- Swiped in the Desktop environment from the left and then re-swiped Firefox Metro into view and ensured that sliding the Navigation App Bar didn't invoke a mouse move
- Ensured that going back to the website after creating a new tab using both methods (overlay/under Tab Navigation) didn't invoke a mouse move when sliding in the Navigation App Bar
- Went through all of the above test cases using several different links from the website provided in both comment #0 and comment #1
- Went through all of the above test cases using filled view (variations of widths)