947211 - [Messages][Drafts] Thread message/draft status (preview, styling and icon) is not accurate for various cases

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect)

Description

[Julien Wajsberg [:julienw]]

This STR is based on the current branch https://github.com/rwaldron/gaia/tree/v1.3-drafts

STR:
1. open an existing thread for a recipient A from where you can send a message
2. write some text
3. press back
4. Save draft
5. send a message to the device from A (different text than the draft's text)
6. wait that the message arrives

Expected:
* The thread is displayed with the unread mark and the sms content is displayed

Actual:
* The thread is displayed with the unread mark and the draft content is displayed

I'm not sure but I may have seen the expected behavior once, so there might be a race too.

The same STR should work with the additional steps too:
7. kill the Messages app with the card switcher
8. start the Messages app again
=> same expectations and results

Comment 1

[Evelyn Eastmond [:evhan55]]

Another way to get the wrong thread preview/status

STR:

1. Go to existing thread
2. Draft a message: 'AAA'
3. Click back. Choose 'Save as Draft'
4. Go back to thread
5. Delete draft text
6. Type a new message: 'BBB'
7. Click send
8. 'BBB' message is sent, composer clears
9. Click back

Expected:
- Thread shows latest message preview.  No draft icon.

Actual:
- Thread shows 'AAA' draft message preview. Draft icon is still there

Comment 3

[Evelyn Eastmond [:evhan55]]

STR:

1. Send an SMS to recipient A
2. Go back to thread list, should see black, non-italic text, no draft icon
3. Go back to thread
4. Draft a new message
5. Click back. Click 'Save as Draft'

Expected:
Thread styling is for a draft: gray, italic, draft icon

Actual:
Thread styling is hybrid: black, non-italic, draft icon

Comment 5

[Rick Waldron [:rwaldron]]

Attachment: https://github.com/rwaldron/gaia/pull/7

Comment 6

[Evelyn Eastmond [:evhan55]]

Comment on attachment 8348200 [details] [review]
https://github.com/rwaldron/gaia/pull/7

Backing out the feedback+

Found a regression:

STR
1) start new message to recipient '333'
2) click back. 'save as draft'
3) two new messages to '333' appear, instead of one draft message to '333'

Comment 7

[Rick Waldron [:rwaldron]]

(In reply to Evelyn Eastmond [:evhan55] from comment #6)
> Comment on attachment 8348200 [details] [review]
> https://github.com/rwaldron/gaia/pull/7
> 
> Backing out the feedback+
> 
> Found a regression:
> 
> STR
> 1) start new message to recipient '333'
> 2) click back. 'save as draft'
> 3) two new messages to '333' appear, instead of one draft message to '333'

Addressed in last push

Comment 8

[Evelyn Eastmond [:evhan55]]

(In reply to Rick Waldron [:rwaldron] from comment #7)
> 
> Addressed in last push

Thank you for catching that.

Comment 9

[Julien Wajsberg [:julienw]]

Comment on attachment 8348200 [details] [review]
https://github.com/rwaldron/gaia/pull/7

Looks fine but has a few bugs to iron out before r+ :)

Comment 10

[Rick Waldron [:rwaldron]]

(In reply to Julien Wajsberg [:julienw] from comment #9)
> Comment on attachment 8348200 [details] [review]
> https://github.com/rwaldron/gaia/pull/7
> 
> Looks fine but has a few bugs to iron out before r+ :)

All comments addressed, rebased onto v1.3-drafts (which has been rebased onto master)

Comment 11

[Julien Wajsberg [:julienw]]

Comment on attachment 8348200 [details] [review]
https://github.com/rwaldron/gaia/pull/7

r=me !

let's land this :)

Comment 12

[Rick Waldron [:rwaldron]]

Landed on v1.3-drafts https://github.com/rwaldron/gaia/commit/0ed474e81608d3b7806652a35d91d79df1e96baa

Comment 13

[Rick Waldron [:rwaldron]]

https://github.com/mozilla-b2g/gaia/commit/2beb8320829e15436c0dd1aabd6cb1ae832ef83a