947708 - Last tab's border in the toolbox tabstrip is much brighter than the rest

Status: RESOLVED FIXED

(DevTools :: Framework, defect)

Description

[Victor Porof [:vporof][:vp]]

Attachment: Screen Shot 2013-12-08 at 16.27.25.png

See screenshot. Happens after bug 941579, at least on OS X.

Comment 1

[Brian Grinstead [:bgrins]]

Attachment: lasttabborder.patch

Uses consistent border color for last tab

Comment 2

[Victor Porof [:vporof][:vp]]

Comment on attachment 8344338 [details] [diff] [review]
lasttabborder.patch

Review of attachment 8344338 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/shared/devtools/toolbars.inc.css
@@ +496,5 @@
>    border-left-width: 0;
>  }
>  
>  .devtools-tab:last-child {
> +  border-right: 1px solid #42484f;

Need to use -moz-border-end and -moz-border-start here and throughout the file for proper localization.

Comment 3

[Victor Porof [:vporof][:vp]]

Attachment: Screen Shot 2013-12-08 at 17.14.54.png

Here's how it looks like on RTL.

Comment 4

[Victor Porof [:vporof][:vp]]

Same comment in bug 947709 applies here as well: https://bugzilla.mozilla.org/show_bug.cgi?id=947709#c2

Let's fix localization for the remaining CSS in a different patch, but at least let's use the proper rules in this bug.

https://wiki.mozilla.org/DevTools/CSSTips

Comment 5

[Brian Grinstead [:bgrins]]

(In reply to Victor Porof [:vp] from comment #4)
> Same comment in bug 947709 applies here as well:
> https://bugzilla.mozilla.org/show_bug.cgi?id=947709#c2
> 
> Let's fix localization for the remaining CSS in a different patch, but at
> least let's use the proper rules in this bug.
> 
> https://wiki.mozilla.org/DevTools/CSSTips

Got it, thanks for the info.  I'm going to upload a patch here that also fixes Bug 947709 since they have become related to each other.

Comment 6

[Brian Grinstead [:bgrins]]

Attachment: tabbar-rtl.patch

This adds rtl support to the tab bar.  It also fixes:

* Brighter border on last tab
* Jiggle on last tab (Bug 947709)
* Opacity on the image when tab is selected isn't 1 (you can see this by selecting a tab then hovering over it - the opacity shouldn't change in this case).

Comment 7

[Victor Porof [:vporof][:vp]]

Comment on attachment 8344344 [details] [diff] [review]
tabbar-rtl.patch

Review of attachment 8344344 [details] [diff] [review]:
-----------------------------------------------------------------

Bokay! Thank you :)

I guess we can dupe the other bugs to this one now.

Comment 8

[Brian Grinstead [:bgrins]]

https://hg.mozilla.org/integration/fx-team/rev/550462c1dae0

Comment 10

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/550462c1dae0