947709 - Selecting the last tab in the toolbox tabstrip jiggles the tab content

Status: RESOLVED DUPLICATE of bug 947708

(DevTools :: Framework, defect)

Description

[Victor Porof [:vporof][:vp]]

Attachment: screencast.gif

See gif. Happens after bug 941579, at least on OS X.

Comment 1

[Brian Grinstead [:bgrins]]

Attachment: lasttab-jiggle.patch

Victor, this patch should fix the problem.  Can you confirm?

Comment 2

[Victor Porof [:vporof][:vp]]

Comment on attachment 8344339 [details] [diff] [review]
lasttab-jiggle.patch

Review of attachment 8344339 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/themes/shared/devtools/toolbars.inc.css
@@ +549,5 @@
>    padding-left: 1px;
>  }
>  
> +.devtools-tab[selected=true]:last-child {
> +  padding-right: 1px;

This fixes the problem, but you need to use -moz-padding-end and -moz-padding-start here and throughout the file.

I think it's better to file a separate patch for localizing all the remaining CSS, but at least let's use the proper rules in this bug.

Basically, if you see "left" and "right" in css, it's probably not localized and shouldn't pass review.

https://wiki.mozilla.org/DevTools/CSSTips#Localization

Comment 3

[Brian Grinstead [:bgrins]]

Fixed by Bug 947708