94802 - Filters UI: can't enable / disable filter via keyboard access

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P2)

Description

[laurel]

Using aug10 commerical trunk build

Keyboard accessibility issue:  Can't disable/enable filters in the filter list
via keyboard only.  I would assume once the line is selected (arrow keys to
navigate up or down within the filter list) hitting the space bar should toggle
the enable/disable (checkmark) state.  It doesn't.

Comment 1

[scottputterman]

We have the same problem in the subscribe dialog (don't know the bug # offhand).  

Comment 2

[Olga]

I see a few issues here: 
1. No mnemonics - it is covered in bug 40761. 
2. No Default Focus: first field: 'Filters For' does not have focus by default.
Only when move Tab here we can use arrow keys to see drop-down list and make
selection by pressing Enter (Space bar does nothing here).
3. Default Control does not work as expected. Example: it does not bring 'Filter
Rules' dialog if we move focus to New by pressing Tab, then press Enter. It is
only closes dialog. Expected: to activate button with the focus.  
4. No fixed size of the dialog. When decrease size, no scroll bars appear (the
same for Subscribe).
5. Unexpected appearance on the status bar without an icon? What is the rule
about this?

It is fine with me to have it as a summary bug. To isolate #4, #5?
Related bug 87693 for Subscribe: OK does not work as expected, only closes dialog.

Comment 3

[scottputterman]

Let's keep this bug to be disabling the keyboard.  We should have separate bugs
on the other items.

Comment 4

[scottputterman]

sorry for the extra email, but my last comment meant to be that we should keep
this bug about disabling the filter via the keyboard.

Comment 5

[(not reading, please use [e-mail] instead)]

taking, just fixed a similar bug in the subscribe dialog.

Comment 6

[(not reading, please use [e-mail] instead)]

accepting

Comment 7

[(not reading, please use [e-mail] instead)]

Attachment: fix for this bug, and fix my fix for #95212 to be simpler / cleaner

Comment 8

[David :Bienvenu]

Comment on attachment 74138 [details] [diff] [review]
fix for this bug, and fix my fix for #95212 to be simpler / cleaner

sr=bienvenu

Comment 9

[(not reading, please use [e-mail] instead)]

Attachment: update patch, to address's concern of ssu.

Comment 10

[Sean Su]

Comment on attachment 74176 [details] [diff] [review]
update patch, to address's concern of ssu.

r=ssu

Comment 11

[David :Bienvenu]

Comment on attachment 74176 [details] [diff] [review]
update patch, to address's concern of ssu.

sr=bienvenu

Comment 12

[Asa Dotzler [:asa]]

Comment on attachment 74176 [details] [diff] [review]
update patch, to address's concern of ssu.

a=asa (on behalf of drivers) for checkin to the 1.0 trunk

Comment 13

[(not reading, please use [e-mail] instead)]

fixed.

Comment 14

[laurel]

OK using mar18 commercial trunk build: win98, mac OS 9.2, linux rh6.2
Able to enable or disable a filter when selected in list using spacebar.

Comment 15

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381