948022 - Use langfile tags to enable new home-page promos

Status: RESOLVED FIXED

(www.mozilla.org :: Bedrock, defect)

Description

[Paul [:pmac] McLanahan]

Once the new langfile-based way is merged from bug 942273, we should use that for the promos and remove the settings-based thing we've been doing. This involves:

1. Modifying the template with the new if blocks, ensuring that we have a broadly translated fallback promo for each of the 4 in the "else" blocks.
2. Deciding the name of the promo tags and whether to use a prefix e.g. "promo-surfing" vs. "surfing".
3. Working with the l10n managers on how to designate and share the names of these promos.

Comment 1

[Pascal Chevrel:pascalc]

I don't think we need to force the use of a prefix but we can use it by social convention for readability of course.

Comment 2

[Paul [:pmac] McLanahan]

(In reply to Pascal Chevrel:pascalc from comment #1)
> I don't think we need to force the use of a prefix but we can use it by
> social convention for readability of course.

Agreed.

Comment 3

[Pascal Chevrel:pascalc]

Template change to use the new feature in in https://github.com/mozilla/bedrock/pull/1506

Tags added to lang files in r123322 on prod

I tested locally and it works for me.

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/6c9b621285ee3e1e8eb952ffb3a9c8a112bdb046
Bug 948022 - update homepage and base.py to use l10n tags for promos

https://github.com/mozilla/bedrock/commit/6134d23ff62c5cdeab333984a2e9ea4333e8801c
Merge pull request #1506 from pascalchevrel/Bug-948022_template_changes_to_use_l10n_tags

Bug 948022 - update homepage and base.py to use l10n tags for promos

Comment 5

[Mike Alexis [:malexis]]

pushed to master in Dec so safe to assume it's on prod. Reopen if more is needed here.