949163 - l10n_has_tag helper should always return true when DEV is True

Status: RESOLVED FIXED

(www.mozilla.org :: Bedrock, defect)

Description

[Paul [:pmac] McLanahan]

:pascalc needs for l10n things to be on in DEV mode (in which www-dev.allizom.org is) so that localizers can see the changes whether the tag has been added or not.

Comment 1

[Mike Alexis [:malexis]]

Still valid and a priority?

Comment 2

[Paul [:pmac] McLanahan]

Not sure it's a priority since we have ways around it for individual instances, but I do believe it's still valid.

Comment 3

[Pascal Chevrel:pascalc]

Still valid, but not a high priority

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/6bd799113662422bce5940656ddb6cc7013b7e5a
Fix bug 920113, 949163: tags should be from all lang files.

Tags (including "active") should be from all .lang files associated with
a template. So l10n_has_tag() as well as the active state of a page
should include information from all included .lang files from
add_lang_file and set_lang_files calls.

This also moves the check for DEV==True to the helpers, so checking
settings.DEV in templates is no longer necessary.

https://github.com/mozilla/bedrock/commit/cd372f930c61a6075ad2a885489770b67a083b1c
Merge pull request #2501 from pmclanahan/l10n_has_tag_use_all_lang_files

Fix bug 920113, 949163: tags should be from all lang files.