948287 - [Download API] Accessing startTime attribute at download start fires NS_ERROR_UNEXPECTED in emulator

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Jason Smith [:jsmith]]

Run the mochitest from bug 945099 with this bug#'s code uncommented. You'll notice that accessing the startTime attribute will fire NS_ERROR_UNEXPECTED during the test. Fabrice thinks this is a failure to initialize this object when creating the download object.

Comment 1

[Aus Lacroix [:aus]]

Attachment: bug948287-dom-downloads-startTime-attribute.diff

This fixes the issue on both desktop and emulator. Also to be noted is that there are tests that verify that this is fixed but they are part of a different bug (bug #945099).

Comment 2

[Jason Smith [:jsmith]]

(In reply to Ghislain 'Aus' Lacroix from comment #1)
> Created attachment 8346896 [details] [diff] [review]
> bug948287-dom-downloads-startTime-attribute.diff
> 
> This fixes the issue on both desktop and emulator. Also to be noted is that
> there are tests that verify that this is fixed but they are part of a
> different bug (bug #945099).

Well, there are tests for this, but we need uncomment the code in that mochitest to ensure this is covered by mochitests.

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/c730a31fd8a7

Comment 4

[Ryan VanderMeulen [:RyanVM]]

Also, please make sure your future patches have commit information included. Makes life much easier for thos landing on your behalf :) Thanks!
https://developer.mozilla.org/en-US/docs/Mercurial_FAQ#How_can_I_generate_a_patch_for_somebody_else_to_check-in_for_me.3F

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/c730a31fd8a7

Comment 6

[Aus Lacroix [:aus]]

Will do! Thanks Ryan!

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a1cfe44bab99