Closed Bug 948314 Opened 6 years ago Closed 6 years ago

[User Story] Rocketbar: Marketplace App Search

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

x86
macOS
defect
Not set

Tracking

(feature-b2g:2.0, tracking-b2g:backlog)

RESOLVED FIXED
1.3 C1/1.4 S1(20dec)
feature-b2g 2.0
tracking-b2g backlog

People

(Reporter: pdol, Assigned: kgrandon)

References

Details

(Whiteboard: [ucid:System152, 1.4:P2, ft:systems-fe][c= p=2 s=2013.12.20 u=],[dependency:Marketplace] )

Attachments

(1 file)

46 bytes, text/x-github-pull-request
vingtetun
: review+
Details | Review
User Story:
As a user, when apps that match my search term are available from Marketplace, I want those apps presented in the search results so that I can easily find and install them.

Acceptance Criteria:
1. I can enter a string and Marketplace apps with names containing that string are displayed.
2. I can enter a string and Marketplace apps matching the entered category are displayed.
3. Selecting an app launches Marketplace, displaying the details of that app.

Assumptions: 
1. Current Marketplace app search (including name and category matching) remains unchanged.
Assignee: nobody → kgrandon
Whiteboard: [ucid:System152, 1.4:P2, ft:systems-fe] → [ucid:System152, 1.4:P2, ft:systems-fe][c= p=3 s= u=]
Attached file Github pull request
Attachment #8350514 - Flags: review?(21)
Comment on attachment 8350514 [details] [review]
Github pull request

r+ with nits
Attachment #8350514 - Flags: review?(21) → review+
Landed: https://github.com/mozilla-b2g/gaia/commit/28676ac8ddbb3fc130deac4e66f1192ba56bcd5c
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [ucid:System152, 1.4:P2, ft:systems-fe][c= p=3 s= u=] → [ucid:System152, 1.4:P2, ft:systems-fe][c= p=2 s=2013.12.20 u=]
Sorry, but why do we put the manifestURLs in the manifest? Is this an agreed rule?
Why not propose a new API to acquire only specific apps to do the communication as you need ? I dislike we are doing this hardcode again and again :(
(In reply to Alive Kuo [:alive][NEEDINFO!] from comment #4)
> Sorry, but why do we put the manifestURLs in the manifest? Is this an agreed
> rule?
> Why not propose a new API to acquire only specific apps to do the
> communication as you need ? I dislike we are doing this hardcode again and
> again :(

Are you referring to manifestURLs for connection rules? I agree - I do not think they should be hard-coded, but potentially pattern-matching. I've expressed this idea in another bug, but it was shot down. Also not sure if this is the right bug you had in mind?
David, should we consider any other search methods for Marketplace apps (outside of matching app name or category)?  If so, what is it possible to query based on the Marketplace APIs?
Flags: needinfo?(dbialer)
Not knowing that much about rocketbar and how search is handled.  But the description of the app and developer name may also be relevant.

Marketplace has its own search API that you may want to use.

Searching on a query string within Marketplace (elasticsearch) uses app Name, app description, developer name with filters as described below - which I can see as useful in some contexts (like firefoxos, tablet, free, offline, languages, regions, etc.).

---
 
http://firefox-marketplace-api.readthedocs.org/en/latest/topics/search.html#search-api

GET /api/v1/apps/search/
    q (string) – The query string to search for.
    cat (int|string) – The category slug or ID to filter by. Use the category API to find the ids of the categories.
    device (string) – Filters by supported device. One of ‘desktop’, ‘mobile’, ‘tablet’, or ‘firefoxos’.
    dev (string) – Enables filtering by device profile if either ‘firefoxos’ or ‘android’.
    pro (string) – A feature profile describing the features to filter by.
    premium_types (string) – Filters by whether the app is free or premium or has in-app purchasing. Any of ‘free’, ‘free-inapp’, ‘premium’, ‘premium-inapp’, or ‘other’.
    type (string) – Filters by type of add-on. One of ‘app’ or ‘theme’.
    app_types (string) – Filters by types of web apps. Any of ‘hosted’, ‘packaged’, or ‘privileged’.
    manifest_url (string) – Filters by manifest URL. Requires an exact match and should only return a single result if a match is found.
    offline (string) – Filters by whether the app works offline or not. ‘True’ to show offline-capable apps; ‘False’ to show apps requiring online support; any other value will show all apps unfiltered by offline support.
    languages (string) – Filters apps by a supported language. Language codes should be provided in ISO 639-1 format, using a comma-separated list if supplying multiple languages.
    region (string) – Filters apps by a supported region. A region code should be provided in ISO 3166 format (e.g., pl). If not provided, the region is automatically detected via requesting IP address. To disable automatic region detection, None may be passed; authentication and one of the ‘Regions:BypassFilters’ permission or curator-level access to a collection are required to do so.
    sort (string) – The fields to sort by. One or more of ‘created’, ‘downloads’, ‘name’, ‘rating’, or ‘reviewed’. Sorts by relevance by default. In every case except ‘name’, sorting is done in descending order.
Flags: needinfo?(dbialer)
Target Milestone: --- → 1.3 C1/1.4 S1(20dec)
Flags: in-moztrap?(jsmith)
No longer blocks: 1.4-systems-fe
Flags: in-moztrap?(jsmith)
Whiteboard: [ucid:System152, 1.4:P2, ft:systems-fe][c= p=2 s=2013.12.20 u=] → [ucid:System152, 1.4:P2, ft:systems-fe][c= p=2 s=2013.12.20 u=],[dependency:Marketplace]
Whiteboard: [ucid:System152, 1.4:P2, ft:systems-fe][c= p=2 s=2013.12.20 u=],[dependency:Marketplace] → [ucid:System152, 1.4:P2, ft:systems-fe][c= p=2 s=2013.12.20 u=]
Whiteboard: [ucid:System152, 1.4:P2, ft:systems-fe][c= p=2 s=2013.12.20 u=] → [ucid:System152, 1.4:P2, ft:systems-fe][c= p=2 s=2013.12.20 u=],[dependency:Marketplace]
blocking-b2g: --- → backlog
feature-b2g: --- → 2.0
blocking-b2g: backlog → ---
You need to log in before you can comment on or make changes to this bug.