94837 - [xlib] xlib port fails to build [nsDeviceContextXlib.cpp:71: `mPaletteInfo' undeclared]

Status: RESOLVED FIXED

(Core :: XUL, defect, P1)

Description

[David Avery]

xlib build dies in gfx/src/xlib :

../../../../gfx/src/xlib/nsDeviceContextXlib.cpp: In method
`nsDeviceContextXlib::nsDeviceContextXlib ()':
../../../../gfx/src/xlib/nsDeviceContextXlib.cpp:71: `mPaletteInfo' undeclared
(first use this function)
../../../../gfx/src/xlib/nsDeviceContextXlib.cpp:71: (Each undeclared identifier
 is reported only once for each function it appears in.)

Comment 1

[John Morrison]

Fallout of imglib1 removal (yanked that member out of the header, but still
referred to it in the implementation). 

Comment 2

[Jason Smith]

The imglib1 removal is bug 78690. I also had this problem, but was able to build
the xlib port (which I'm running now) when I applied Tomi Leppikangas's patch
from the imglib1 bug that finishes off the xlib changes, along with my patch
from bug 91954 which appears to fix some makefile problems in xprint.

Comment 3

[Roland Mainz]

Fix is attachment 44654 [details] [diff] [review] ...

OK... requesting r=/sr= for
http://bugzilla.mozilla.org/showattachment.cgi?attach_id=44654 , please...

Comment 4

[timeless]

i'm building w/ disable-debug i think and i die here (w/ patch applied):
"/tmp/mozilla/gfx/src/xlib/nsRenderingContextXlib.cpp", line 89: Error: 
RenderingContextXlibLM is not defined.
"/tmp/mozilla/gfx/src/xlib/nsRenderingContextXlib.cpp", line 89: Error: 
PR_LOG_DEBUG is not defined.
[repeated a lot for different lines]
preprocess output shows that RenderingContextXlibLM is being preprocessed out, 
but i can't figure out why the PR_LOG calls aren't...

Comment 5

[timeless]

ok i found my problem and am going to check in the imglib remainder.

Comment 6

[Roland Mainz]

timeless:
Can I mark this bug as FIXED or are there any pieces left which need to be fixed
first ?

Comment 7

[timeless]

well, xlib built, but it crashes in one of the other well known places.

Comment 8

[Roland Mainz]

Where does it crash ? BugID ?

Comment 9

[John Morrison]

May God have mercy on us all. The 212 bug spam-o-rama is Now!