91954 - [xlib] xlib port : bad include path in gfx/src/xprint

Status: VERIFIED DUPLICATE of bug 100851

(Core Graveyard :: Printing: Xprint, defect)

Description

[Chris Morgan]

From Bugzilla Helper:
User-Agent: Mozilla/4.7 [en] (X11; I; SunOS 5.8 sun4u)
BuildID:    

I built the xlib-only port of the latest code from cvs on SPARC/Solaris 8 i.e.
--enable-toolkit=xlib.
During the build, libgfxxprint.so would not link due to missing references to
nsFontMetricsXlib.o nsRenderingContextXlib.o and nsRegionXlib.o I discovered I
could fix the link by replaying the link command prefixing each of the .o files
mentioned with ../xlib/
The build then ran to completion.

Reproducible: Always
Steps to Reproduce:
./configure  --disable-mailnews '--enable-optimize=-O3 -fpermissive' --disable
-debug --enable-strip-libs --disable-md --enable-xterm-updates --disable-dtd-deb
ug --enable-toolkit=xlib
make -f client.mk

Actual Results:  libgfxxprint.so did not link

Expected Results:  makefile needs to be adjusted to find the object code needed
to link libgfxxprint.so

I was asked to assign this to : [e-mail] on
the newsgroup netscape.public.mozilla.unix

Comment 1

[Jason Smith]

I'm able to reproduce this one. I'm a newbie, but it looks like a problem in
gfx/src/xprint/Makefile.in

Comment 2

[Roland Mainz]

Accepting bug, setting milestone to 0.9.4 for now.

Reporter:
1. The _exact_ error message of the build failure is important.
2. Which version of GNU make are you using ("gmake -v") ?
3. Which compiler are you using ?

Comment 3

[Xan Lopez]

Ok, here it is the exact error message for this problem (Note: "No existe el
fichero o directorio" is the spanish phrase for "No such file or directory"):

c++ -I/usr/X11R6/include -fno-rtti -fno-exceptions -Wall -Wconversion
-Wpointer-arith -Wbad-function-cast -Wcast-align -Woverloaded-virtual -Wsynth
-pedantic -Wno-long-long -pipe -pthread -O3  -DNDEBUG -DTRIMMED
-I/usr/X11R6/include -shared -Wl,-h -Wl,libgfxxprint.so -o libgfxxprint.so 
../xlibrgb/xlibrgb.o xprintutil.o xprintutil_printtofile.o nsDeviceContextXP.o
nsFontMetricsXlib.o nsRenderingContextXlib.o nsGfxFactoryXP.o nsXPrintContext.o
nsRegionXlib.o nsGCCache.o    -L/usr/X11R6/lib -lXp -lXext -lX11
-L../../../dist/bin -lxpcom -L../../../dist/bin -L/home/xan/cvs/mozilla/dist/lib
-lplds4 -lplc4 -lnspr4 -lpthread -ldl -lc  
-Wl,--version-script,../../../build/unix/gnu-ld-scripts/components-version-script
-L../../../dist/bin -L../../../dist/lib -lgkgfx -L../../../dist/bin -lxpcom
-L../../../dist/bin -L/home/xan/cvs/mozilla/dist/lib -lplds4 -lplc4 -lnspr4
-lpthread -ldl -lc   -ldl -lm  -lc   

c++: nsFontMetricsXlib.o: No existe el fichero o el directorio
c++: nsRenderingContextXlib.o: No existe el fichero o el directorio
c++: nsRegionXlib.o: No existe el fichero o el directorio
c++: nsGCCache.o: No existe el fichero o el directorio
make[3]: *** [libgfxxprint.so] Error 1
make[3]: Leaving directory `/home/xan/cvs/mozilla/gfx/src/xprint'
make[2]: *** [install] Error 2
make[2]: Leaving directory `/home/xan/cvs/mozilla/gfx/src'
make[1]: *** [install] Error 2
make[1]: Leaving directory `/home/xan/cvs/mozilla/gfx'
make: *** [install] Error 2
aiur:~/cvs/mozilla%

I'm using gcc 2.95.4 and GNU make 3.79.1, hope it helps :)

Comment 4

[Roland Mainz]

cls:
Is VPATH support broken in gmake 3.79.1 ?

Comment 5

[cls]

*blink*  No, VPATH is not broken in 3.79.1.  This is a classic srcdir/VPATH
build problem.  We've been down this road before (with xlibrgb).  Your choices
are to use relative paths like xlibrgb.c or implement local build rules that
change the name of the output files like
mozilla/modules/zlib/standalone/Makefile.in does.

Comment 6

[Roland Mainz]

_Ouch_. 
I am boned...

Stuff in modules/zlib/standalone/Makefile.in is far out of my scope. 
cls... wanna help me, please ?

Comment 7

[Jason Smith]

The stuff in modules/zlib/standalone/Makefile.in is beyond me as well. However,
using relative paths seems to be the easiest solution. Using relative paths to
point to the problem files makes it build for me once I include the xlib patch
from bug 78690. I'll attach my patch below. I get a seg fault when I try to run
the build, but I don't know if this is a problem with my patch or if it's unrelated.

Comment 8

[Jason Smith]

Attachment: Use relative paths to fix build bustage

Comment 9

[Roland Mainz]

AFAIK that patch will break StaticBuild stuff. Xlib and Xprint uses same sources
but the resulting binaries differ (thats bug 90380 ("Get rid of |#ifdef
_IMPL_NS_XPRINT|")). the resulting *.o files must not be put in the same dir or
havoc will occur... ;-(

Comment 10

[Roland Mainz]

Retargeting to 0.9.5 for now... ;-((

Comment 11

[cls]

*** This bug has been marked as a duplicate of 100782 ***

Comment 12

[cls]

Argh, duped it on the wrong bug.

Comment 13

[cls]

*** This bug has been marked as a duplicate of 100851 ***

Comment 14

[Roland Mainz]

Verifying.