Closed Bug 948743 Opened 12 years ago Closed 12 years ago

nsINetworkService::GetNetworkInterfaceStats broken by change to netd

Categories

(Firefox OS Graveyard :: General, defect)

Product:
Firefox OS Graveyard
Component:
General
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:1.3+, firefox27 wontfix, firefox28 fixed, firefox29 fixed, b2g-v1.3 fixed, b2g-v1.3T fixed, b2g-v1.4 fixed)

Status:
RESOLVED FIXED
Milestone:
1.3 C2/1.4 S2(17jan)
Project Flags:
blocking-b2g 1.3+
Tracking Flags:
Tracking Status
firefox27 --- wontfix
firefox28 --- fixed
firefox29 --- fixed
b2g-v1.3 --- fixed
b2g-v1.3T --- fixed
b2g-v1.4 --- fixed

People

(Reporter: mschwart, Assigned: chucklee)

References

Details

(Keywords: regression)

Attachments

(1 file, 2 obsolete files)

Query interface stat directly. V2
6.44 KB, patch
Details | Diff | Splinter Review
Calls to nsINetworkService::GetNetworkInterfaceStats callback with success=false (expected true). This happens because Google has deprecated the readrxcounter/readtxcounter messages that net_worker.js depends on. See Change-Id: I6b113294b46e5988ad606144c3eef3c846ac28d1 This breaks anyone that uses that API including the Usage app.
blocking-b2g: --- → 1.3?
(1.3+, we need this API working)
blocking-b2g: 1.3? → 1.3+
Andrew, Can you please reassign appropriately? Not getting traction here.
Flags: needinfo?(overholt)
Ken or Jason will know who can deal with this breakage.
Flags: needinfo?(overholt) → needinfo?(kchang)
Chuck, could you please take this bug?
Flags: needinfo?(kchang) → needinfo?(chulee)
Assignee: nobody → chulee
Flags: needinfo?(chulee)
Comment on attachment 8349280 [details] [diff] [review] WIP - Query interface stat directly. Review of attachment 8349280 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me
Attachment #8349280 - Flags: feedback?(vchang) → feedback+
Comment on attachment 8349280 [details] [diff] [review] WIP - Query interface stat directly. Review of attachment 8349280 [details] [diff] [review]: ----------------------------------------------------------------- Looks good to me
Attachment #8349280 - Flags: feedback?(acperez)
Comment on attachment 8349280 [details] [diff] [review] WIP - Query interface stat directly. Nice!
Attachment #8349280 - Flags: feedback?(acperez) → feedback+
Attached patch Query interface stat directly. (obsolete) — — Splinter Review
Attachment #8349280 - Attachment is obsolete: true
Attachment #8355154 - Flags: review?(vchang)
Attachment #8355154 - Flags: review?(acperez)
Keywords: regression
Comment on attachment 8355154 [details] [diff] [review] Query interface stat directly. Review of attachment 8355154 [details] [diff] [review]: ----------------------------------------------------------------- Looks good for me.
Attachment #8355154 - Flags: review?(vchang) → review+
Attachment #8355154 - Flags: review?(acperez) → review+
Chuck, Can you please provide an updated patch for this blocker?
Flags: needinfo?(chulee)
Andrew, Are Ben/Blade working on this blocker?
Flags: needinfo?(overholt)
(In reply to Preeti Raghunath(:Preeti) from comment #15) > Andrew, > > Are Ben/Blade working on this blocker? No, that's a different bug.
Flags: needinfo?(overholt)
The tests fail seems not related to patch, I am still finding why.
Flags: needinfo?(chulee)
Change return value to behave like netd.
Attachment #8355154 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/aa13e666470a
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.3 C2/1.4 S2(17jan)
Depends on: 961007
Flags: in-testsuite?
Flags: in-moztrap-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: