948824 - [CostControl] [DSDS] Remove IccHelper

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Marina Rodríguez [:mai]]

To have dual sim support we have to remove IccHelper from CostControl.

Comment 1

[Marina Rodríguez [:mai]]

Attachment: proposal patch v1

Could you give me your feedback about the proposal?

Regards

Comment 2

[Salvador de la Puente González [:salva]]

Comment on attachment 8345969 [details]
proposal patch v1

Ok, it is going well but please take into account the comments on GitHub and my telephonic feedback before asking for review. The main point of improvements are:

- Not address other bugs such as Airplane Mode. If you consider they are bugs, check if they are reproducing on master and open specific bugs for them. Note some can be not bugs but not considered situations.

- Focus on removing IccHelper, we can avoid code duplication if we load once and only once the ICC info for the proper SIM (updating when DSDS configuration change) and keeping that object as the replacement of IccHelper.

Comment 3

[Marina Rodríguez [:mai]]

Comment on attachment 8345969 [details]
proposal patch v1

Please, could you review the code?
Regards

Comment 4

[Salvador de la Puente González [:salva]]

Comment on attachment 8345969 [details]
proposal patch v1

Good work but review my comments on GtitHub. Once addressed, ask for the review one more time. 

Thank you!

Comment 5

[Marina Rodríguez [:mai]]

Comment on attachment 8345969 [details]
proposal patch v1

Please, could you review the patch?

Comment 6

[Salvador de la Puente González [:salva]]

Comment on attachment 8345969 [details]
proposal patch v1

Please, before merging, re-launch Travis and wait for green. Ping me if problems.

Thank you :mai, happy new year and welcome back to work! ,)

Comment 7

[Marina Rodríguez [:mai]]

Master: 33e4a0f4e242b54c91eb8a1f5f91efada5252565

Comment 8

[Salvador de la Puente González [:salva]]

We have checked for landing bug 963682 which is 1.3+ we will need this as well.

Comment 9

[David Scravaglieri [:scravag]]

Blocks a blocker.

Comment 10

[Noemí Freire (:noemi)]

Hi John,

Could you please help us with the uplift of this patch to v1.3 branch?. Many thanks!!

Comment 11

[Anthony Ricaud (:rik)]

Uplifted to v1.3 with 190b3e90ec8b93bd44155bd7dbac29143d902f58.