Closed Bug 965792 Opened 10 years ago Closed 10 years ago

[Costcontrol] Error on FTE when cardState change

Categories

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Cost Control
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:1.3+, b2g-v1.3 fixed)

Status:
RESOLVED FIXED
Milestone:
1.4 S1 (14feb)
Project Flags:
blocking-b2g 1.3+
Tracking Flags:
Tracking Status
b2g-v1.3 --- fixed

People

(Reporter: mai, Assigned: mai)

References

Details

(Keywords: regression)

User Story

On the FTE, if the cardState has a state different to "ready" when the iccInfo changes, the application cannot detect it because the function called on the oniccinfochange event does not exist.

This bug is produced by "Bug 948824 -[CostControl] [DSDS] Remove IccHelper"

https://github.com/mozilla-b2g/gaia/blob/master/apps/costcontrol/js/fte.js#L32

Attachments

(1 file)

patch v1.0
46 bytes, text/x-github-pull-request
salva
: review+
Details | Review 
On the FTE, if the cardState have an state different to ready, when the iccInfo changes the application can not detect it because the function called on the oniccinfochange does not exist.

This bug is produced by "Bug 948824 -[CostControl] [DSDS] Remove IccHelper"

https://github.com/mozilla-b2g/gaia/blob/master/apps/costcontrol/js/fte.js#L32
Assignee: nobody → mri
Keywords: regression
User Story: (updated)
Attached file patch v1.0 — 
Please, could you review the code?
Attachment #8367938 - Flags: review?(salva)
Is this a regression then caused by bug 948824? Should this be nomed since the other bug is 1.3?
(In reply to Jason Smith [:jsmith] from comment #2)
> Is this a regression then caused by bug 948824? Should this be nomed since
> the other bug is 1.3?

Yes, you are right, nominating to v1.3?. Thanks for raising it!.
blocking-b2g: --- → 1.3?
Blocks: 948824
Can we get an understanding of the user impact here?
Flags: needinfo?(mri)
User Impact: In case the cardstate/iccInfo changes (SIM Card status changes from ready to other one) while the app is launching and loading the FTE process then the CC app won't save the user preferences (alarms, data usage, billing period,...) due to doesn't know for which SIM Card the info corresponds to.
Flags: needinfo?(mri)
(In reply to marina rodríguez [:mai] from comment #5)
> User Impact: In case the cardstate/iccInfo changes (SIM Card status changes
> from ready to other one) while the app is launching and loading the FTE
> process then the CC app won't save the user preferences (alarms, data usage,
> billing period,...) due to doesn't know for which SIM Card the info
> corresponds to.

Okay - that sounds potentially bad, so I'll block this.
blocking-b2g: 1.3? → 1.3+
Comment on attachment 8367938 [details] [review]
patch v1.0

Edge case but a bug obviously. Nice and harmless fix.
Thank you :mai!
Attachment #8367938 - Flags: review?(salva) → review+
Master: 9ee1e2833281354e20e93607f83d13ae45d37aec
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
status-b2g-v1.3: --- → affected
Target Milestone: --- → 1.4 S1 (14feb)
Uplifted 9ee1e2833281354e20e93607f83d13ae45d37aec to:
v1.3: cae35033284b9715dceed5ae7a10adf3a9f24dc6
status-b2g-v1.3: affected → fixed
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: