948870 - onpeerready still hooked when app is killed

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[John Hu [:johnhu][:johu][:醬糊小弟]]

Attachment: shrink_on_homescreen.png

When an app puts onpeerready callback and is killed, the system app can still show shrink UI on home screen. After some investigation, the system app can still find onpeerready callback through API call.

Comment 1

[psiddh]

Hi, I will look into this. It looks like an issue with the code. Application ID should be cleared off when that particular application gets killed.

Thanks

Comment 2

[psiddh]

Attachment: (v1) Bug 948870 : Remove AppID from registered list when killed r=allstars.chh

Comment 3

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 8358682 [details] [diff] [review]
(v1) Bug 948870 : Remove AppID from registered list when killed r=allstars.chh

Review of attachment 8358682 [details] [diff] [review]:
-----------------------------------------------------------------

Can't we reuse peerTargetMap to find out the appId?

Comment 4

[psiddh]

Yes, I think we can reuse peerTargetMap,  using Object.keys. Wonders of JS dictionary type objects :)
Will upload another patch

Comment 5

[psiddh]

Attachment: (v2) Bug 948870 : Remove target info from registered list when killed r=allstars.chh

Comment 6

[psiddh]

Latest try results: https://tbpl.mozilla.org/?tree=Try&rev=5c5e5c1320cf&pusher=[e-mail]

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/951118dd877c

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/951118dd877c

Comment 9

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Actually I found the root cause if Bug 996522.
And the patch landed in this bug doesn't work, file Bug 1003775 for this.