949012 - Nexus 4 build scripts/configuration should correctly set GAIA_DEV_PIXELS_PER_PX

Status: RESOLVED FIXED

(Firefox OS Graveyard :: General, defect)

Description

[Dietrich Ayala (:dietrich)]

Attachment: Screenshot 2013-12-11 09.11.54.png

screenshot attached. compare to the crispness of the text.

Comment 1

[Dietrich Ayala (:dietrich)]

Hi Patryk! Who's working on icons these days?

Comment 2

[Eric Pang [:epang] UX]

(In reply to Dietrich Ayala (:dietrich) from comment #1)
> Hi Patryk! Who's working on icons these days?

Hey Dietrich, I checked on my helix and I'm not seeing this issue.  When you flash to you device are you adding "GAIA_DEV_PIXELS_PER_PX=1.5"?  I just found out about this, I thought all the icons were fuzzy too!

When flashing, use this command instead:
GAIA_DEV_PIXELS_PER_PX=1.5 make reset-gaia

Let me know if this doesn't fix the issue.  Thanks!
Eric

Comment 3

[Dietrich Ayala (:dietrich)]

That did solve the problem, thanks Eric. Perhaps the Nexus 4 build configuration is not properly setting that value.

Converting this bug to cover that case.

Comment 4

[Dietrich Ayala (:dietrich)]

in gaia: http://mxr.mozilla.org/gaia/search?string=GAIA_DEV_PIXELS_PER_PX

Comment 5

[Julien Wajsberg [:julienw]]

I think we never set this env, it's up to the builder to specify it.

(but I might be wrong)

Comment 6

[Dietrich Ayala (:dietrich)]

It should be done in the configure step, where the builder specifies what phone they're building for.

Comment 7

[Julien Wajsberg [:julienw]]

I agree :)

Comment 8

[Dietrich Ayala (:dietrich)]

Mwu, where would i put this in the build configs?

Comment 9

[Marco Chen [:mchen]]

Refer to Helix, it is set in full_helix.mk.
https://github.com/mozilla-b2g/device-helix/blob/master/full_helix.mk#L35

Comment 10

[Dietrich Ayala (:dietrich)]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/device-mako/pull/10

Comment 11

[Michael Wu [:mwu]]

You're almost there.

device.mk is the right file in this case, I believe we have a bunch of gecko specific changes near the end of that file.

Also, you submitted the change on the wrong branch - we use 4.3 for the nexus 4 at the moment.

Comment 12

[Dietrich Ayala (:dietrich)]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/device-mako/pull/12

Comment 13

[Dietrich Ayala (:dietrich)]

Argh, wrong branch again.

Comment 14

[Dietrich Ayala (:dietrich)]

Attachment: Link to Github pull-request: https://github.com/mozilla-b2g/device-mako/pull/13

Comment 15

[Michael Wu [:mwu]]

Merged.