949044 - App dimensions is not correctly resize after minimizing the call screen

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

When the call screen is minimized apps are normally resized in order to fit the remaining space. This works great but when the call screen is closed, the next time the app is opened it has the wrong dimensions.

I found that the if (app.resized) app.resize() call in window_manager.js does not succeed since resize() wait for the app to be active.

Alive I don't understand the reason of this check, so I removed it. Let me know what are the side effects of that.

Also this patch only fix the issue for 1.3 for now. I need to check if it happens on 1.4 with the new window management code.

Comment 1

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Attachment: bug949044.patch for 1.3

the 1.3 patch.

Comment 2

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

The patch may apply for 1.4 but i need to check that it happens here as well.

Comment 3

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 8346039 [details] [diff] [review]
bug949044.patch for 1.3

Review of attachment 8346039 [details] [diff] [review]:
-----------------------------------------------------------------

The reason is I don't want a background app to be resized but if window manager has the correct active window reference this may be redundant.
I'll check this bug in AppWindow#v1.4 too.

Comment 4

[(inactive after 6/18) Alive Kuo [:alive]]

This doesn't occur on v1.4 :)

Comment 5

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

Triager, are you looking at this bug ?

Comment 6

[Tim Guan-tin Chien [:timdream] (please needinfo)]

There was unfortunate some confusing involving who should triage Gaia::System::Window Mgmt but we will start triage this today.

Comment 7

[Mozilla Shepherd (This account is used for automation and doesn't receive bugmail)]

Attachment: mozilla-b2g:v1.3 PR#15142

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

I've submitted a pull request to land the patch.

Comment 9

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Vivien,

I tried to land this v1.3-only patch for you but it looks like there is a Travis-CI error. If it's not related please go ahead and merge it.

Comment 10

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #9)
> Vivien,
> 
> I tried to land this v1.3-only patch for you but it looks like there is a
> Travis-CI error. If it's not related please go ahead and merge it.

Should not be. I will investigate and land it myself if needed. Thanks for trying :)

Comment 12

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Vivien, are you still working on this?

Comment 13

[Peter Dolanjski [:pdol]]

PM retriaged this and we agree with the blocking status.

Comment 14

[Vivien Nicolas (:vingtetun) (:21) - (NOT reading bugmails, needinfo? please)]

https://github.com/mozilla-b2g/gaia/commit/ab82bb45a605318b4f31c6b8321a7af272a05c20

Seems green to me. Sorry for the delay.