949264 - Allow using union members in codegenerated events

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Boris Zbarsky [:bzbarsky]]

Andrea needs it, and anyway it's good to have it working.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: part 1. Share more codegen between events and CGNativeMember.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: part 2. Support union members in generated events.

Comment 3

[Olli Pettay [:smaug] (vacation July 18 - 31)]

Comment on attachment 8346270 [details] [diff] [review]
part 1.  Share more codegen between events and CGNativeMember.

But please file a bug to make codegen to use sane coding style for
params. (aFoo, not foo)

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: part 3. Use aRetVal for the outparam return value for CGNativeMember.

Comment 5

[Olli Pettay [:smaug] (vacation July 18 - 31)]

Comment on attachment 8346273 [details] [diff] [review]
part 2.  Support union members in generated events.


>             if nullable:
>                 dictType = CGTemplatedType("Nullable", dictType)
>             args.append(Argument("%s&" % dictType.define(), "retval"))
>+        elif returnType.isUnion():
>+            args.append(Argument("%s&" %
>+                                 CGUnionStruct.unionTypeDecl(returnType, True),
>+                                 "retval"))
aRetVal

>+        if type.isUnion():
>+            return "retval = " + memberName + ";"
And then change this too.

>+                elif typeNeedsRooting(m.type):
>+                    raise TypeError("Need to implement tracing for event "
>+                                    "member of type %s" % m.type)

OK, this can be done later if needed.

Comment 6

[Boris Zbarsky [:bzbarsky]]

> aRetVal

That's done in part 3.

> OK, this can be done later if needed.

Indeed.  I just wanted the codegen to scream and die if the case ever comes up, rather than silently not tracing.

Comment 7

[Boris Zbarsky [:bzbarsky]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fe7c562b3cc7
https://hg.mozilla.org/integration/mozilla-inbound/rev/ebd95b488dc1
https://hg.mozilla.org/integration/mozilla-inbound/rev/1d09a0b29c10

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/fe7c562b3cc7
https://hg.mozilla.org/mozilla-central/rev/ebd95b488dc1
https://hg.mozilla.org/mozilla-central/rev/1d09a0b29c10

Comment 9

[Noemí Freire (:noemi)]

Hi

This bug blocks a blocker for v1.3 (Bug 946316). Because of this, nominating this bug for v1.3. Thanks!

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5ee1b0c4fc42
https://hg.mozilla.org/releases/mozilla-aurora/rev/bdd7de70155c
https://hg.mozilla.org/releases/mozilla-aurora/rev/a224f09028ea