Closed
Bug 949264
Opened 12 years ago
Closed 12 years ago
Allow using union members in codegenerated events
Categories
(Core :: DOM: Core & HTML, defect)
Tracking
()
People
(Reporter: bzbarsky, Assigned: bzbarsky)
References
(Blocks 1 open bug)
Details
Attachments
(3 files)
5.72 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
9.81 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
7.51 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
Andrea needs it, and anyway it's good to have it working.
![]() |
Assignee | |
Comment 1•12 years ago
|
||
Attachment #8346270 -
Flags: review?(bugs)
![]() |
Assignee | |
Updated•12 years ago
|
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
![]() |
Assignee | |
Comment 2•12 years ago
|
||
Attachment #8346273 -
Flags: review?(bugs)
![]() |
Assignee | |
Updated•12 years ago
|
Blocks: ParisBindings
Comment 3•12 years ago
|
||
Comment on attachment 8346270 [details] [diff] [review]
part 1. Share more codegen between events and CGNativeMember.
But please file a bug to make codegen to use sane coding style for
params. (aFoo, not foo)
Attachment #8346270 -
Flags: review?(bugs) → review+
![]() |
Assignee | |
Comment 4•12 years ago
|
||
Attachment #8346584 -
Flags: review?(bugs)
Updated•12 years ago
|
Attachment #8346584 -
Flags: review?(bugs) → review+
Comment 5•12 years ago
|
||
Comment on attachment 8346273 [details] [diff] [review]
part 2. Support union members in generated events.
> if nullable:
> dictType = CGTemplatedType("Nullable", dictType)
> args.append(Argument("%s&" % dictType.define(), "retval"))
>+ elif returnType.isUnion():
>+ args.append(Argument("%s&" %
>+ CGUnionStruct.unionTypeDecl(returnType, True),
>+ "retval"))
aRetVal
>+ if type.isUnion():
>+ return "retval = " + memberName + ";"
And then change this too.
>+ elif typeNeedsRooting(m.type):
>+ raise TypeError("Need to implement tracing for event "
>+ "member of type %s" % m.type)
OK, this can be done later if needed.
Attachment #8346273 -
Flags: review?(bugs) → review+
![]() |
Assignee | |
Comment 6•12 years ago
|
||
> aRetVal
That's done in part 3.
> OK, this can be done later if needed.
Indeed. I just wanted the codegen to scream and die if the case ever comes up, rather than silently not tracing.
![]() |
Assignee | |
Comment 7•12 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/fe7c562b3cc7
https://hg.mozilla.org/integration/mozilla-inbound/rev/ebd95b488dc1
https://hg.mozilla.org/integration/mozilla-inbound/rev/1d09a0b29c10
Flags: in-testsuite+
Target Milestone: --- → mozilla29
https://hg.mozilla.org/mozilla-central/rev/fe7c562b3cc7
https://hg.mozilla.org/mozilla-central/rev/ebd95b488dc1
https://hg.mozilla.org/mozilla-central/rev/1d09a0b29c10
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 9•11 years ago
|
||
Hi
This bug blocks a blocker for v1.3 (Bug 946316). Because of this, nominating this bug for v1.3. Thanks!
blocking-b2g: --- → 1.3?
Updated•11 years ago
|
status-b2g-v1.3:
--- → affected
Updated•11 years ago
|
blocking-b2g: 1.3? → 1.3+
Comment 10•11 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/5ee1b0c4fc42
https://hg.mozilla.org/releases/mozilla-aurora/rev/bdd7de70155c
https://hg.mozilla.org/releases/mozilla-aurora/rev/a224f09028ea
status-b2g-v1.4:
--- → fixed
status-firefox27:
--- → wontfix
status-firefox28:
--- → fixed
status-firefox29:
--- → fixed
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•