Closed Bug 949271 Opened 7 years ago Closed 7 years ago

Support unions inside sequences/variadics in JS-implemented codegen

Categories

(Core :: DOM: Core & HTML, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla29
blocking-b2g 1.3+
Tracking Status
firefox27 --- wontfix
firefox28 --- fixed
firefox29 --- fixed
b2g-v1.3 --- fixed
b2g-v1.4 --- fixed

People

(Reporter: bzbarsky, Assigned: bzbarsky)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Our callback codegen for unions is really old and didn't get updated when we introduced owning unions.  Simple to fix using the bits in bug 949264.
I discovered while adding the tests that in the meantime someone had fixed bug 863948, so uncommenting those tests too
Attachment #8346280 - Flags: review?(bugs)
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #8346280 - Flags: review?(bugs) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/46e29a05206d
Flags: in-testsuite+
Target Milestone: --- → mozilla29
https://hg.mozilla.org/mozilla-central/rev/46e29a05206d
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Blocks bug 946316.
blocking-b2g: --- → 1.3?
Blocks: 946316
blocking-b2g: 1.3? → 1.3+
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.