Closed Bug 949525 Opened 7 years ago Closed 7 years ago
VP9 test files
There should be a vp9 test file (content/media/vp9.webm) to test vp9 support.
We should add two files to content/media/test/ that contain vp9+opus, a *short* one (duration around 0.5s) that is included in gSmallTests (in content/media/test/manifest.js), and a longer one (say around 5s) which we add to gPlayedTests. Part of the reason that our mochitests take so long to run is that we have files that aren't short in gSmallTests. gSmallTests is meant to be used to test that the files can load or do a quick play through without stressing the decoders.
I propose vp9cake.webm for the longer test. vp9+opus, muxed with mkvmerge, 8 seconds, audio shorter than video, 139K.
0.5 seconds of cake
Comment on attachment 8347172 [details] [diff] [review] 0001-Bug-949525-VP9-tests.patch Review of attachment 8347172 [details] [diff] [review]: ----------------------------------------------------------------- You need to `hg add` or equivalent the vp9.webm and vm9cake.webm files.
Attachment #8347172 - Flags: review?(cpearce) → review+
include webm files in patch, carrying forward review.
Backed out in https://hg.mozilla.org/integration/b2g-inbound/rev/b1d1c9098751 for causing various assertions like https://tbpl.mozilla.org/php/getParsedLog.php?id=32056533&tree=B2g-Inbound
Turns out there's a bug in mkvmerge which I used to make the first version of vp9cake.webm. It (or we) still aren't completely correct, but this file is better, and doesn't assert during playback. I filed bug 951770 about tightening our validity checking.
Updated patch to include the new vp9cake.webm and replace vp9.webm with a video only test based on seek.webm.
Green on try. Carrying forward r=cpeace. https://tbpl.mozilla.org/?tree=Try&rev=091dbf933e1a
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Are there any more automated tests needed for this feature?
(In reply to Mihaela Velimiroviciu [QA] (:mihaelav) from comment #14) > Are there any more automated tests needed for this feature? not aware of any other tests that would be needed at this time.
You need to log in before you can comment on or make changes to this bug.