Closed Bug 949525 Opened 7 years ago Closed 7 years ago

VP9 test files

Categories

(Core :: Audio/Video, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: j, Assigned: j)

References

Details

Attachments

(1 file, 5 obsolete files)

There should be a vp9 test file (content/media/vp9.webm) to test vp9 support.
Assignee: nobody → j
Depends on: 833023
We should add two files to content/media/test/ that contain vp9+opus, a *short* one (duration around 0.5s) that is included in gSmallTests (in content/media/test/manifest.js), and a longer one (say around 5s) which we add to gPlayedTests.

Part of the reason that our mochitests take so long to run is that we have files that aren't short in gSmallTests. gSmallTests is meant to be used to test that the files can load or do a quick play through without stressing the decoders.
Attached video vp9cake.webm (obsolete) —
I propose vp9cake.webm for the longer test. vp9+opus, muxed with mkvmerge, 8 seconds, audio shorter than video, 139K.
Attached video vp9.webm (obsolete) —
0.5 seconds of cake
Attached patch 0001-Bug-949525-VP9-tests.patch (obsolete) — Splinter Review
Attachment #8347172 - Flags: review?(cpearce)
Comment on attachment 8347172 [details] [diff] [review]
0001-Bug-949525-VP9-tests.patch

Review of attachment 8347172 [details] [diff] [review]:
-----------------------------------------------------------------

You need to `hg add` or equivalent the vp9.webm and vm9cake.webm files.
Attachment #8347172 - Flags: review?(cpearce) → review+
Attached patch 0001-Bug-949525-VP9-tests.patch (obsolete) — Splinter Review
include webm files in patch, carrying forward review.
Attachment #8346897 - Attachment is obsolete: true
Attachment #8347170 - Attachment is obsolete: true
Attachment #8347172 - Attachment is obsolete: true
Keywords: checkin-needed
Blocks: 950793
Attached video remuxed vp9cake.webm (obsolete) —
Turns out there's a bug in mkvmerge which I used to make the first version of vp9cake.webm. It (or we) still aren't completely correct, but this file is better, and doesn't assert during playback.

I filed bug 951770 about tightening our validity checking.
Updated patch to include the new vp9cake.webm and replace vp9.webm with a video only test based on seek.webm.
Attachment #8347935 - Attachment is obsolete: true
Attachment #8349536 - Attachment is obsolete: true
Green on try. Carrying forward r=cpeace.

https://tbpl.mozilla.org/?tree=Try&rev=091dbf933e1a
https://hg.mozilla.org/mozilla-central/rev/a9b4dbde503d
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Are there any more automated tests needed for this feature?
Flags: needinfo?(j)
(In reply to Mihaela Velimiroviciu [QA] (:mihaelav) from comment #14)
> Are there any more automated tests needed for this feature?

not aware of any other tests that would be needed at this time.
Flags: needinfo?(j)
Depends on: 1034081
You need to log in before you can comment on or make changes to this bug.