949675 - Support HTTP->Rtsp Channel redirects

Status: VERIFIED FIXED

(Firefox OS Graveyard :: RTSP, defect)

Description

[Honza Bambas (:mayhemer)]

Right now all the job of rtsp handling is done on the child process.  This is a) insecure and unwanted b) doesn't support being redirected to (http->rtsp doesn't work).

Comment 1

[Ken Chang[:kenkai]]

It blocks 1.4 feature.

Comment 3

[Jason Duell]

Honza, correct me if I'm wrong, but I'm guessing the solution here is to have RTSPChannelChild implement nsIChildChannel (and RtspChannelParent implement nsIParentChannel), like FTPChannel{Child|Parent} do, and then have the RtspParentChannel call ConnectChannel if it's been created as part of a redirect?
  
  http://mxr.mozilla.org/mozilla-central/source/netwerk/protocol/ftp/FTPChannelParent.cpp#77

The situation is complicated by the fact that we seem to have a split between RtspChannel and then the e10s is done somehow by RtspChannelController--I'm not sure how that maps onto this.  But hopefully it's enough to get Ethan/Steve thinking about things at least.

(Note: the IPDL magic that creates FTPChannelCreationArgs as a type is in /netwerk/ipc/NeckoChannelParams.ipdlh)

Comment 4

[Jason Duell]

RTSP has never mapped neatly onto our regular necko channels, so Honza thinks we may have an easier time supporting it by implementing bug 590682 and having it use the universal redirect logic instead.

Comment 5

[Honza Bambas (:mayhemer)]

I think we should give a try to bug 590682.  There is a work-in-progress patch that allows universally wrap any nsIChannel implantation that can only work on the parent process to allow it to be used from child process.  The patch needs to be rebased tho.


Ethan, first, check that we can rip all e10s code from the current RTSP implementation and that their nsIChannel implementation conforms the contract (see the IDL, ask questions).  If it's confirmed as doable and there is no extra e10s communication (means: they DON'T send anything more then just OnStartRequest, OnDataAvailable, OnStopRequest) then it's IMO doable.

Then, please take bug 590682 and make the patch apply on top of current mozilla-central and make it build again.  It should be easy, mostly mechanical work, still, it's quite old, so some APIs or so might changed since that time.  Ask me or Jason when something is not clear.

Comment 6

[Honza Bambas (:mayhemer)]

(In reply to Honza Bambas (:mayhemer) from comment #5)
> Ethan, first, check that we can rip all e10s code from the current RTSP
> implementation and that their nsIChannel implementation conforms the
> contract (see the IDL, ask questions).  If it's confirmed as doable and
> there is no extra e10s communication (means: they DON'T send anything more
> then just OnStartRequest, OnDataAvailable, OnStopRequest) then it's IMO
> doable.

The goal is to let it work only on parent process on in the single process model.

Comment 7

[Honza Bambas (:mayhemer)]

parent process OR in the single process model.

(3:30am....)

Comment 8

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

remove 1.4 flag as this is a feature work. let's use bug dependency to manage.

Comment 9

[Ethan Tseng [:ethan]]

Attachment: rtsp-channel-child-wip.patch

An initial WIP patch, which implements RtspChannelChild.
1. Inherit from nsIChildChannel, in order to use CompleteRedirectSetup().
2. Transfer the creation of RtspController from RtspMediaResource to RtspChannelChild.
3. Add itself to LoadGroup so that we can release RtspController via channel::Cancel().

Comment 10

[Ethan Tseng [:ethan]]

Attachment: refactor-rtspchannel-wip.patch

Update the WIP patch.

Comment 11

[Ethan Tseng [:ethan]]

Attachment: refactor-rtspchannel-wip.patch

Comment 12

[Ethan Tseng [:ethan]]

Attachment: rtsp-redirect.patch

A WIP patch for http->rtsp redirection.

Comment 13

[Ethan Tseng [:ethan]]

Attachment: rtsp-redirect.patch

Remove trailing whitespaces.

Comment 14

[Ethan Tseng [:ethan]]

This bug will be resolved in bug 992568 (Refactor RtspChannel to support HTTP->RTSP redirection and rendering inside the browser), which converging implementations of several bugs.

Comment 15

[Ethan Tseng [:ethan]]

Resolved fixed by bug 992568.

Verified by two different HTTP->RTSP redirect cases:
1. Shorten URL:
http://goo.gl/G437gm
will be redirected to:
rtsp://m.streaming.imusica.com.br/vod/mp4:takemeout?=3529931==web.local=1262=0

2. Redirect specified in HTTP URL
http://tiv-dmz.homeip.net/content/sdpgen/h264_192kbps_aacPlus_24kbps_3sec_QVGA_10_fps.sdp?redirect=1&sessionID=jSN1gtpJV1pbbxum
(This site requires authentication. User/passwd: VQGTester/VQG8017)

Comment 16

[Ethan Tseng [:ethan]]

*** Note ***
RTSP video is not enabled by default for now.
Turn on it by manually setting preference:
pref("media.rtsp.video.enabled", true);

Bug 999914 will turn on RTSP video.

Comment 17

[William Hsu [:whsu]]

Verified it.

* Build information.
 - Gaia      e8a08a3f7a608993f0b302371e016e73faceea70
 - Gecko     https://hg.mozilla.org/mozilla-central/rev/2897fb554990
 - BuildID   20140505160203
 - Version   32.0a1