949853 - When recording from lockscreen and then tapping home button, the video would not show in the Gallery app

Status: RESOLVED DUPLICATE of bug 1019120

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Peter deHaan [:pdehaan]]

B2G 1.2.0.0-prerelease (12/12/2013 build)

Steps to reproduce:
0. I have password lock homescreen, may or may not be relevant.
1. From the lock screen, press the camera icon.
2. Take a photo of ____.
3. Take a video of ____. Instead of stopping the video recording, press the home button.
4. At the login screen, enter your password and go to the gallery app.

Actual results:
Photo was saved to gallery, video was not.

Expected results:
When hitting the "home" button, the video should be saved to the SD card instead of randomly deleted.

Comment 1

[Mike Habicher [:mikeh] (high bugzilla latency)]

In comment 0, step 0 is very likely the key: videos are recorded with a temporary filename and then renamed when recording is stopped. I suspect this isn't happening in the STR above.

Comment 2

[David Flanagan [:djf]]

Yuck. Do we still make a private copy of the camera app into the system app to handle the lockscreen case?  If so, what happens to it when you tap Home?  I wonder if it gets killed right away.

The fix would have to be either to stop the system app from killing the camera right away and give it some kind of signal.  Or modify gecko or the camera firmware to write the desired file even if the initiating app gets killed.

Tim: are you still handling the lockscreen? Is the camera still built in to the lockscreen in 1.2? Could we modify the system app to delay killing the camera for 10 seconds or so after hiding it to give the app time to save the recorded file?

Comment 3

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to David Flanagan [:djf] from comment #2)
> Yuck. Do we still make a private copy of the camera app into the system app
> to handle the lockscreen case?  If so, what happens to it when you tap Home?
> I wonder if it gets killed right away.

Yes, unfortunately we still do that. A better solution would be launching the camera app and put the frame in a <div id="locked-windows">, handled by the same AppWindowManager code in v1.4. We could make sure only certified app is allowed to be launched in the locked window layer.

> The fix would have to be either to stop the system app from killing the
> camera right away and give it some kind of signal. 

Depend on the 1.3 blocking status of this bug, we might want to take this solution for now. Triage should make a decision on that.

> Or modify gecko or the
> camera firmware to write the desired file even if the initiating app gets
> killed.
> 
> Tim: are you still handling the lockscreen? Is the camera still built in to
> the lockscreen in 1.2? Could we modify the system app to delay killing the
> camera for 10 seconds or so after hiding it to give the app time to save the
> recorded file?

No, Alive and Greg is handling window manager and lock screen, respectively.

Comment 4

[Jason Smith [:jsmith]]

Does this reproduce on 1.1?

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

Proposed solution based on #3:
in Lockscreen: new AppWindow with specified manifestURL(camera) + config.oop = false;
and change the containerElement. before the iframe is rendered. Or have a secureWindow based on AppWindow.

BTW, if ~10 sec is really enough we could do some dirty stuff in lockscreen for v1.3..

Comment 6

[Nikolai Khristoforov]

This bug reproduces on the 1.1 MOZ build. When accessing the Camera app from a passcode lockscreen, the picture is saved, but the video does not get saved.

Comment 7

[Nikolai Khristoforov]

Environmental Variables for comment 6:
Device: Buri 1.1 MOZ
BuildID: 20131213041208
Gaia: 6ff3a607f873320d00cb036fa76117f6fadd010f
Gecko: bdac595a4e46
Version: 18.0
Firmware Version: V1.2_20131115

Comment 8

[Greg Weng [:snowmantw][:gweng][:λ]]

I've asked John and tried a possible solution, but it didn't work. I'll try another way to solve this ASAP.

Comment 9

[Hema Koka [:hema]]

Tim, 

Lets try get this fixed in 1.4 (not blocking for 1.3 -- if people feel that we need to block on it, please comment)

thanks
hema

Comment 10

[Greg Weng [:snowmantw][:gweng][:λ]]

Attachment: cant_reproduce.ogv

John and I can't reproduce this on Inari and Unagi, all with v1.2 branch build.
This is the video.

Comment 11

[Greg Weng [:snowmantw][:gweng][:λ]]

Can QA help us to reproduce this bug, or confirm that it's disappeared?

Comment 12

[Nikolai Khristoforov]

The bug still reproduces on the latest 1.2 build. The video does appear in the Gallery app after unlocking the homescreen with the passcode. The video in comment 10 shows the video in the Video app, not the Gallery app. For the latest 1.2 build, the video appears in the Video app as well.

Device: Buri 1.2 COM
BuildID: 20140102004001
Gaia: b1bc88386c781148a25091bf2eeee3ba217281d0
Gecko: 0c11156c7d9b
Version: 26.0
RIL Version: 01.02.00.019.102
Firmware Version: V1.2_20131115

Comment 13

[Jason Smith [:jsmith]]

Nikolai - I don't follow what's being claimed to still reproduce here. Can you give more details? What from this bug is still present?

Comment 14

[Nikolai Khristoforov]

The recurring problem is that the video does not appear in the Gallery app. After following the STR with a passcode enabled locksreen:
1. From the lock screen, press the camera icon.
2. Take a photo of ____.
3. Take a video of ____. Instead of stopping the video recording, press the home button.
4. At the login screen, enter your password and go to the gallery app.

The Gallery app shows the picture that was taken, but does not show the video. However, the video does appear in the Video app which is what the video shows in comment 10.

Comment 15

[Greg Weng [:snowmantw][:gweng][:λ]]

So the problem is NOT that the video got no recorded, but it doesn't appear in the Gallery app.

I think we should change the title... it contains "Video isnt saved" which is not correct anymore.

Comment 16

[Greg Weng [:snowmantw][:gweng][:λ]]

John told me that the Camera app would exit normally even press home key to leave. So I would take a look to see what's the difference between these two cameras.

Comment 17

[John Hu [:johnhu][:johu][:醬糊小弟]]

That's not correct in comment 16.

There is no difference between Camera app and Secured Camera. They are identical. What we need is to check the different of handling normal window and secured camera in system app.

Comment 18

[Greg Weng [:snowmantw][:gweng][:λ]]

This bug now seems because we would create a iframe to contain our own private camera, but destroy it directly without handle the leaving logic of the camera. So the correct way would be handling the leaving jobs of the camera while we want to destroy it.

(Although the most *right* way should be eliminating this private camera forever).

Comment 19

[Greg Weng [:snowmantw][:gweng][:λ]]

It seems the Camera app has the same symptom, too. The only difference is that it would hardly happen on the app, because user would take longer time to kill it from card view due to the flow (although we still can reproduce it carefully).

So right now the only thing I can do in this bug is to let the camera in the lockscreen leaving as the Camera app does (push to background or hide it while press the home key).

Comment 20

[Greg Weng [:snowmantw][:gweng][:λ]]

(The bug I mentioned: Bug 957910)

Comment 21

[Greg Weng [:snowmantw][:gweng][:λ]]

(Don't know whether it should set the dependency or not, so if I'm wrong please just remove it).

Comment 22

[Dave Hylands [:dhylands]]

Any update on this?

Comment 23

[Greg Weng [:snowmantw][:gweng][:λ]]

No. As I said, this issue is shared between the ordinary Camera and LockScreen. If you leave the Camera app in a very fast speed, just like what user would do in this bug, you will get the same result. So we need a solution to solve the root cause. See Bug 957910.

Comment 24

[Preeti Raghunath(:Preeti)]

Hema

Is LG expecting this fix? Is this needed for the camera work in 1.4?

Comment 25

[Jason Smith [:jsmith]]

(In reply to Preeti Raghunath(:Preeti) from comment #24)
> Hema
> 
> Is LG expecting this fix? Is this needed for the camera work in 1.4?

This is an old bug - not a regression. We don't need to block on this.

Comment 26

[Hema Koka [:hema]]

(In reply to Preeti Raghunath(:Preeti) from comment #24)
> Hema
> 
> Is LG expecting this fix? Is this needed for the camera work in 1.4?

I don't think so

Comment 27

[Hema Koka [:hema]]

(In reply to Jason Smith [:jsmith] from comment #25)
> (In reply to Preeti Raghunath(:Preeti) from comment #24)
> > Hema
> > 
> > Is LG expecting this fix? Is this needed for the camera work in 1.4?
> 
> This is an old bug - not a regression. We don't need to block on this.

Right, removing it from nomination

Comment 28

[Justin D'Arcangelo [:justindarc]]

Closing this as a duplicate of Bug 1019120 (even though its really the other way around). A patch to fix this has recently landed to master.