949876 - B2G RIL: setRadioEnabled bug in concurrent cases

Status: RESOLVED FIXED

(Firefox OS Graveyard :: RIL, defect)

Description

[Szu-Yu Chen [:aknow] (inactive)]

Some defect in original code when gecko receive two setRadioEnabled request at the same time.

Comment 1

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: Fix setRadioEnabled queueing method

1. Should also queue the new request if the previous one is still working.
2. should do "this._processNextMessage();" after "this.request = null;". Otherwise, the new request object may be overwritten to null unexpectedly.

Comment 2

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Thanks aknow !

I just update the dependency on this bug.

Comment 3

[Hsin-Yi Tsai (she/her) | away [:hsinyi]]

Comment on attachment 8347024 [details] [diff] [review]
Fix setRadioEnabled queueing method

Review of attachment 8347024 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good!

Comment 4

[Wesley Huang [:wesley_huang] (EPM) (NI me)]

set to 1.3+ for this blocks bug 945140, which is important bug fixing.

Comment 5

[Szu-Yu Chen [:aknow] (inactive)]

Attachment: [Final] Fix setRadioEnabled queueing method. r=hsinyi

Comment 6

[Szu-Yu Chen [:aknow] (inactive)]

https://tbpl.mozilla.org/?tree=Try&rev=b6554298676d

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/2fbd4bd129e2

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/2fbd4bd129e2

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/f1529e29e805

Comment 10

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Thanks aknow, 

I will update gaia part after got green from Travis !