949908 - There should be only one way to start/stop tracing in the debugger

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Victor Porof [:vporof][:vp]]

There's a button in the Traces tab that reads "Start Tracing". After pressing that, there's no corresponding "Stop Tracing" in the tab.

Initially I had no idea how to stop tracing, because I missed the tracer button in the toolbar.

We should have a more consistent way of starting/stopping tracing. I vote for having a single button, either in the toolbar, or in the traces tab.

Comment 1

[Victor Porof [:vporof][:vp]]

Moreover, once you stop tracing, the "Start Tracing" button in the sidebar never comes back. Confusing.

Comment 2

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

As I said in bug 949909, I think we should remove the "start tracing" button and only show the "tracing has not started" message and center that message in the pane.

Comment 3

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: tracing-one-way-to-toggle-tracing.patch

This one's a doozie.

Comment 4

[Victor Porof [:vporof][:vp]]

Comment on attachment 8349548 [details] [diff] [review]
tracing-one-way-to-toggle-tracing.patch

Review of attachment 8349548 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/devtools/debugger/debugger.xul
@@ -395,5 @@
>                  <description value="&debuggerUI.tracingNotStarted.label;" />
> -                <button id="start-tracing"
> -                        class="devtools-toolbarbutton"
> -                        command="startTracing"
> -                        label="&debuggerUI.startTracing;"/>

Please file a bug about using the emptyText setter on the widget instead of providing this custom tracer message.

Comment 5

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

https://hg.mozilla.org/integration/fx-team/rev/1cc2d61ff1a8

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/1cc2d61ff1a8