951795 - Use WidgetMethod's empty text attribute instead of a deck in the tracer

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

<accidental submit>

We should use emptyText instead of having a deck and a custom <description> element for when the tracer doesn't have any logs.

Question: Should we differentiate between not-tracing and tracing-but-no-logs-yet? Right now we do, but with emptyText, I'm not sure we would without going out of our way to do so.

Comment 2

[Victor Porof [:vporof][:vp]]

(In reply to Nick Fitzgerald [:fitzgen] from comment #1)

I think this should work fine by changing the emptyText value when clearing the logs, and when stopping tracing.

Comment 3

[Victor Porof [:vporof][:vp]]

Attachment: tracer-empty-text.patch

Works. Needs a test.

Comment 4

[Rob Campbell [:rc] (:robcee)]

No test, No beer.

P3.

Comment 5

[Victor Porof [:vporof][:vp]]

Attachment: v2

Added test.

Comment 6

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Comment on attachment 8355791 [details] [diff] [review]
v2

Review of attachment 8355791 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

::: browser/devtools/debugger/test/browser_dbg_tracing-05.js
@@ +23,5 @@
> +      waitForSourceShown(gPanel, "code_tracing-01.js")
> +        .then(testTracingNotStartedText)
> +        .then(() => gTracer._onStartTracing())
> +        .then(testFunctionCallsUnavailableText)
> +        .then(clickButton)

Task.jsm if you want.

::: browser/themes/osx/devtools/widgets.css
@@ +297,5 @@
> +}
> +
> +.theme-light .fast-list-widget-empty-text {
> +  padding: 4px 8px;
> +  color: GrayText;

I thought we weren't supposed to be using |GrayText| in theme CSS?

Why did you change the colors at all? They were theme colors before.

Comment 7

[Victor Porof [:vporof][:vp]]

(In reply to Nick Fitzgerald [:fitzgen] from comment #6)
> 
> I thought we weren't supposed to be using |GrayText| in theme CSS?
> Why did you change the colors at all? They were theme colors before.

Normalization. I'm taking better care of that in bug 943883.

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/19a7e3bd47c3

Comment 9

[Alfred Kayser]

I see transform:translateZ(0), but on other places it is: transform:translateZ(1px).
1. Will 0 also work? 
2. Will 1px have possibly other unwanted effects?

Comment 10

[Victor Porof [:vporof][:vp]]

(In reply to Alfred Kayser from comment #9)
> I see transform:translateZ(0), but on other places it is:
> transform:translateZ(1px).
> 1. Will 0 also work? 
> 2. Will 1px have possibly other unwanted effects?

Both work, and should have no side-effects (apart from hw accel) as far as I know.