Closed Bug 950032 Opened 7 years ago Closed 7 years ago

Remove dead code from japanese.map

Categories

(Core :: Internationalization, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla29

People

(Reporter: emk, Assigned: emk)

Details

(Whiteboard: [qa-])

Attachments

(3 files)

gIndexShiftJis, gIndexJis0208, and gIndex are not used anymore. It will only cause confusion (see bug 949923).
Attachment #8347219 - Flags: review?(smontagu)
Comment on attachment 8347219 [details] [diff] [review]
Part 1: Remove dead code from japanese.map

Review of attachment 8347219 [details] [diff] [review]:
-----------------------------------------------------------------

This is great as far as it goes, but I think there are still blocks of dead data in gJapaneseMap which the patch doesn't touch. Do you want to go the extra mile and rebuild the table without the data that is no longer referenced? The tool that build japanese.map was apparently never checked in, but there is an early version in attachment 98510 [details] [diff] [review] for bug 108136.
Attachment #8347219 - Flags: review?(smontagu) → review+
Attachment #8347715 - Flags: review?(smontagu)
Attachment #8347716 - Flags: review?(smontagu)
Attachment #8347219 - Attachment description: patch → Part 1: Remove dead code from japanese.map
For the record, IBM943.TXT was taken from <http://bugzilla.mozilla.gr.jp/attachment.cgi?id=259>.
Other mapping files are taken from Unicode Data Files <http://www.unicode.org/Public/MAPPINGS/>.
Attachment #8347715 - Flags: review?(smontagu) → review+
Comment on attachment 8347716 [details] [diff] [review]
Part 3: Update jamap.pl to the latest tip

Review of attachment 8347716 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!
Attachment #8347716 - Flags: review?(smontagu) → review+
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.