Closed
Bug 950032
Opened 8 years ago
Closed 7 years ago
Remove dead code from japanese.map
Categories
(Core :: Internationalization, defect)
Core
Internationalization
Tracking
()
RESOLVED
FIXED
mozilla29
People
(Reporter: emk, Assigned: emk)
Details
(Whiteboard: [qa-])
Attachments
(3 files)
3.18 KB,
patch
|
smontagu
:
review+
|
Details | Diff | Splinter Review |
10.23 KB,
patch
|
smontagu
:
review+
|
Details | Diff | Splinter Review |
79.51 KB,
patch
|
smontagu
:
review+
|
Details | Diff | Splinter Review |
gIndexShiftJis, gIndexJis0208, and gIndex are not used anymore. It will only cause confusion (see bug 949923).
Assignee | ||
Comment 1•8 years ago
|
||
Attachment #8347219 -
Flags: review?(smontagu)
Assignee | ||
Comment 2•8 years ago
|
||
Try run: https://tbpl.mozilla.org/?tree=Try&rev=08a6fc8d8440
Comment 3•7 years ago
|
||
Comment on attachment 8347219 [details] [diff] [review] Part 1: Remove dead code from japanese.map Review of attachment 8347219 [details] [diff] [review]: ----------------------------------------------------------------- This is great as far as it goes, but I think there are still blocks of dead data in gJapaneseMap which the patch doesn't touch. Do you want to go the extra mile and rebuild the table without the data that is no longer referenced? The tool that build japanese.map was apparently never checked in, but there is an early version in attachment 98510 [details] [diff] [review] for bug 108136.
Attachment #8347219 -
Flags: review?(smontagu) → review+
Assignee | ||
Comment 4•7 years ago
|
||
Attachment #8347715 -
Flags: review?(smontagu)
Assignee | ||
Comment 5•7 years ago
|
||
Attachment #8347716 -
Flags: review?(smontagu)
Assignee | ||
Updated•7 years ago
|
Attachment #8347219 -
Attachment description: patch → Part 1: Remove dead code from japanese.map
Assignee | ||
Comment 6•7 years ago
|
||
For the record, IBM943.TXT was taken from <http://bugzilla.mozilla.gr.jp/attachment.cgi?id=259>. Other mapping files are taken from Unicode Data Files <http://www.unicode.org/Public/MAPPINGS/>.
Assignee | ||
Comment 7•7 years ago
|
||
Try run: https://tbpl.mozilla.org/?tree=Try&rev=efa1f7a2fca0
Updated•7 years ago
|
Attachment #8347715 -
Flags: review?(smontagu) → review+
Comment 8•7 years ago
|
||
Comment on attachment 8347716 [details] [diff] [review] Part 3: Update jamap.pl to the latest tip Review of attachment 8347716 [details] [diff] [review]: ----------------------------------------------------------------- Nice!
Attachment #8347716 -
Flags: review?(smontagu) → review+
Assignee | ||
Comment 9•7 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/82e0ca3cb55c https://hg.mozilla.org/integration/mozilla-inbound/rev/d5f003d1b55d https://hg.mozilla.org/integration/mozilla-inbound/rev/6f940326dd62
Assignee: nobody → VYV03354
Status: NEW → ASSIGNED
Comment 10•7 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/82e0ca3cb55c https://hg.mozilla.org/mozilla-central/rev/d5f003d1b55d https://hg.mozilla.org/mozilla-central/rev/6f940326dd62
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
Updated•7 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•