950032 - Remove dead code from japanese.map

Status: RESOLVED FIXED

Description

[Masatoshi Kimura [:emk]]

gIndexShiftJis, gIndexJis0208, and gIndex are not used anymore. It will only cause confusion (see bug 949923).

Comment 1

[Masatoshi Kimura [:emk]]

Attachment: Part 1: Remove dead code from japanese.map

Comment 2

[Masatoshi Kimura [:emk]]

Try run: https://tbpl.mozilla.org/?tree=Try&rev=08a6fc8d8440

Comment 3

[Simon Montagu :smontagu]

Comment on attachment 8347219 [details] [diff] [review]
Part 1: Remove dead code from japanese.map

Review of attachment 8347219 [details] [diff] [review]:
-----------------------------------------------------------------

This is great as far as it goes, but I think there are still blocks of dead data in gJapaneseMap which the patch doesn't touch. Do you want to go the extra mile and rebuild the table without the data that is no longer referenced? The tool that build japanese.map was apparently never checked in, but there is an early version in attachment 98510 [details] [diff] [review] for bug 108136.

Comment 4

[Masatoshi Kimura [:emk]]

Attachment: Part 2: Import jamap.pl from bug 108136

Comment 5

[Masatoshi Kimura [:emk]]

Attachment: Part 3: Update jamap.pl to the latest tip

Comment 6

[Masatoshi Kimura [:emk]]

For the record, IBM943.TXT was taken from <http://bugzilla.mozilla.gr.jp/attachment.cgi?id=259>.
Other mapping files are taken from Unicode Data Files <http://www.unicode.org/Public/MAPPINGS/>.

Comment 7

[Masatoshi Kimura [:emk]]

Try run: https://tbpl.mozilla.org/?tree=Try&rev=efa1f7a2fca0

Comment 8

[Simon Montagu :smontagu]

Comment on attachment 8347716 [details] [diff] [review]
Part 3: Update jamap.pl to the latest tip

Review of attachment 8347716 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!

Comment 9

[Masatoshi Kimura [:emk]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/82e0ca3cb55c
https://hg.mozilla.org/integration/mozilla-inbound/rev/d5f003d1b55d
https://hg.mozilla.org/integration/mozilla-inbound/rev/6f940326dd62

Comment 10

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/82e0ca3cb55c
https://hg.mozilla.org/mozilla-central/rev/d5f003d1b55d
https://hg.mozilla.org/mozilla-central/rev/6f940326dd62