950046 - [holly] Empty row in Web Developer Menu on Windows

Status: VERIFIED FIXED

(DevTools :: General, defect)

Description

[Ada [:adalucinet]]

Attachment: Screenshot showing this issue

Not reproducible on: Firefox 27 beta 1 (Build ID: 20131209204824)
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:27.0) Gecko/20100101 Firefox/27.0
Reproducible on: latest Aurora (Build ID: 20131212004008) 
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0
Reproducible on: latest Holly (Build ID: 20131212040201)
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0

STR:
1. Launch Firefox.
2. Go to Firefox Menu -> Web Developer

Expected results: No empty row displayed between App Manager and Browser Console.

Actual results: An empty row is displayed between App Manager and Browser Console.

Notes: 
1. Only reproducible on Windows OS.
2. Regression range will be posted as soon as found.

Comment 1

[Matt Brubeck (:mbrubeck)]

The empty menu item is this one:
<menuitem id="appmenu_chromeDebugger" observes="devtoolsMenuBroadcaster_ChromeDebugger"/>

There is no such broadcaster on Aurora/Holly:
http://mxr.mozilla.org/mozilla-aurora/search?string=devtoolsMenuBroadcaster_ChromeDebugger

It was removed by bug 912057.

Comment 2

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Add Browser Toolbox to app menu

Fixes up the app menu in Holly.  Will request Aurora after landing there.

Try (build only): https://tbpl.mozilla.org/?tree=Try&rev=35b23b18312c

Comment 4

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Verified this fixes the issue in a local VM.

Landed on Holly: https://hg.mozilla.org/projects/holly/rev/5f145f2b29b8

Comment 5

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8347564 [details] [diff] [review]
Add Browser Toolbox to app menu

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 912057
User impact if declined: Empty / broken menu item in the Firefox app menu
Testing completed (on m-c, etc.): holly
Risk to taking this patch (and alternatives if risky): Low
String or IDL/UUID changes made by this patch: None

Comment 6

[Ada [:adalucinet]]

Mozilla/5.0 (X11; Linux x86_64; rv:29.0) Gecko/20100101 Firefox/29.0 
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:29.0) Gecko/20100101 Firefox/29.0

Verified as fixed on latest Holly 29.0a1 (Build ID: 20131218040202).

Comment 7

[Lukas Blakk [:lsblakk] use ?needinfo]

Triage drive-by - waiting for this to land on central before approving uplift.

Comment 8

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Lukas Blakk [:lsblakk] from comment #7)
> Triage drive-by - waiting for this to land on central before approving
> uplift.

It won't be in this case, as the change is Aurora / Holly specific.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/a42fe878d29b

Comment 10

[Ioana (away)]

Verified as fixed on the 01/08 Firefox 28.0a2:
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:28.0) Gecko/20100101 Firefox/28.0