Closed
Bug 950075
Opened 12 years ago
Closed 12 years ago
Defect - Form history autofill suggestions (and "undefined") replace what I'm typing unpredictably
Categories
(Firefox for Metro Graveyard :: Input, defect, P2)
Tracking
(firefox27 unaffected, firefox28 verified, firefox29 verified)
VERIFIED
FIXED
Firefox 28
| Tracking | Status | |
|---|---|---|
| firefox27 | --- | unaffected |
| firefox28 | --- | verified |
| firefox29 | --- | verified |
People
(Reporter: mbrubeck, Assigned: mbrubeck)
References
Details
(Keywords: regression, Whiteboard: [beta28] p=1)
Attachments
(1 file)
|
1.49 KB,
patch
|
rsilveira
:
review+
lsblakk
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
While typing in a text input field with the form history popup visible (for example, the "Summary" field in Bugzilla), I frequently and apparently randomly see my typed text suddenly replaced by a form history entry. I also sometimes see "undefined" inserted into the form field.
Possibly related to bug 919232, though I haven't tested to verify that.
|
||
Updated•12 years ago
|
|
Assignee | |
Comment 1•12 years ago
|
||
Forwarding non-navigation key events to the list was causing it to select items based on the typed letters. This patch limits the proxying to list navigation keys only.
Marco: I'd like to add this bug to iteration 21, p=1.
Assignee: nobody → mbrubeck
Status: NEW → ASSIGNED
Attachment #8347298 -
Flags: review?(rsilveira)
Flags: needinfo?(mmucci)
|
|
||
Comment 2•12 years ago
|
||
Added to IT#21.
Flags: needinfo?(mmucci)
Priority: -- → P2
QA Contact: jbecerra
Whiteboard: [beta28] → [beta28] p=1
|
||
Comment 3•12 years ago
|
||
Comment on attachment 8347298 [details] [diff] [review]
patch
Review of attachment 8347298 [details] [diff] [review]:
-----------------------------------------------------------------
Makes total sense, thanks for fixingthis!
Attachment #8347298 -
Flags: review?(rsilveira) → review+
|
|
Assignee | |
Updated•12 years ago
|
status-firefox27:
--- → unaffected
status-firefox28:
--- → affected
status-firefox29:
--- → fixed
Keywords: regressionwindow-wanted → regression
OS: Windows 8.1 → All
Hardware: x86_64 → All
|
|
Assignee | |
Comment 4•12 years ago
|
||
|
|
Assignee | |
Updated•12 years ago
|
|
||
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 29
|
|
Assignee | |
Comment 6•12 years ago
|
||
Comment on attachment 8347298 [details] [diff] [review]
patch
[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 939705
User impact if declined: Text you type in form fields is randomly overwritten.
Testing completed (on m-c, etc.): On m-c since 12/13.
Risk to taking this patch (and alternatives if risky): Very low-risk Metro-only patch. Just moves a single line of code so it's not run at inappropriate times.
String or IDL/UUID changes made by this patch: None.
Attachment #8347298 -
Flags: approval-mozilla-aurora?
|
||
Updated•12 years ago
|
Attachment #8347298 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
|
|
Assignee | |
Comment 7•12 years ago
|
||
|
||
Updated•12 years ago
|
Target Milestone: Firefox 29 → Firefox 28
|
||
Comment 8•12 years ago
|
||
Verified as fixed for iteration #21, with latest Nightly and Aurora on Win 8 64-bit and 32-bit: text I type in form fields isn't randomly overwritten.
Status: RESOLVED → VERIFIED
Keywords: verifyme
|
||
Comment 9•11 years ago
|
||
Setting in-qa-testsuite- since we don't support Metro anymore
Flags: in-qa-testsuite? → in-qa-testsuite-
You need to log in
before you can comment on or make changes to this bug.
Description
•