950242 - [curated groups] Admin can't add user to curated group

Status: VERIFIED FIXED

(Participation Infrastructure :: Phonebook, defect)

Description

[Justin Crawford [:hoosteeno] [:jcrawford]]

Steps to reproduce: 
* As an administrator, edit a user profile (e.g. http://sancus.ca/admin/auth/user/12661/)
* Add the user to a curated group (e.g. "miata")
* Visit the group and look for the user (http://sancus.ca/en-US/group/miata/)

Expected: The user is in the group

Actual: The user is not

Comment 1

[Dan Poirier [:dpoirier]]

With the latest code on sancus.ca, the admin page for a user does not pretend to allow modifying a user's group memberships. Given the complexity now of adding and removing users from groups, I suggest we leave it this way. https://bugzilla.mozilla.org/show_bug.cgi?id=699630 will allow a cuator to invite users to join a group.

Comment 2

[Justin Crawford [:hoosteeno] [:jcrawford]]

Regarding comment 1, admins have always been able to (and have occasionally needed to) manage /all/ group memberships from /admin. The curated group features we've built apply to curated groups, but there are other groups too. We need to allow admins to manage them.

Comment 3

[Dan Poirier [:dpoirier]]

Okay, I think we will be able to add the ability to edit group members from the group's admin page. 

For technical reasons, adding/removing groups from a user's admin page is not easily doable, but there will be at least one way to work with memberships in the admin.

Comment 4

[Dan Poirier [:dpoirier]]

Pull request https://github.com/mozilla/mozillians/pull/764

Comment 5

[[github robot]]

Commits pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/aaee5f65a180bcef6defb893dacd9b393695c540
Bug 950242 - Admin management of group membership

Allow Django admins to manage group members as inlines on the group's
admin page.

This will work fine for reasonable-sized groups, but will get unwieldy
when groups get really large.  We might be better off managing group
membership from a user's page, since a user is unlikely to belong to
so many groups that that would get too big. Unfortunately, Django currently
doesn't support nested inlines in the admin, which would be required
because we already implement the user admin by making the userprofile
an inline on the user page, and the membership would have to be an
inline on the userprofile.

A better way for admins to manage memberships might be directly in
the GroupMembership model. To make that easier, I've added a search
field to that admin changelist page that searches on a bunch of fields
in the groups and users associated with the membership records. It
shouldn't be hard to find a user's memberships or membership in a
group, or just add a new membership.

Fixes bug 950242

https://github.com/mozilla/mozillians/commit/cfab0febe63cc49944376fcb23c12d1147ebf1ae
Merge pull request #764 from caktus/950242-admin-group-members

Bug 950242 - Admin management of group membership

Comment 6

[William Reynolds [:williamr]]

Attachment: Django mult-select filter UI

(In reply to [github robot] from comment #5)
> Allow Django admins to manage group members as inlines on the group's
> admin page.

I think allowing an admin to manage a user's group memberships from that user's profile (on the site or the admin panel) would be quite useful. My biggest use case is to remove a former staff member from the 'staff' group and add them to the 'alumni' group. 

Django has a UI widget that may be useful here (screenshot attached). We could use the left select box to display all groups and the right box to display groups that a user has membership of. This two-box approach does not handle memberships that are requested, though that state is not a common use case for an admin. We could also add a third box for groups where membership is requested. I'd love more feedback on this idea.

I like Group Membership model - the Date Joined field might especially be handy in the future.

Comment 7

[Justin Crawford [:hoosteeno] [:jcrawford]]

This was merged per comment 5. Please create new bugs for enhancement features.

Comment 8

[Giorgos Logiotatidis [:giorgos]]

More related commits: https://github.com/mozilla/mozillians/commit/ea6d98f5b91e6988e3d00e99796b6edcf6303211

Comment 9

[[github robot]]

Commits pushed to master at https://github.com/mozilla/mozillians

https://github.com/mozilla/mozillians/commit/5bb8f2d0b503f7fbc6d3e66721c46ded185913f7
[fix bug 950242] Include 'username' in VouchedUserProfileAutocomplete.

https://github.com/mozilla/mozillians/commit/ec39b334a62655c1bbc3eb49909e47a51f9107b1
Merge pull request #771 from glogiotatidis/950242

[fix bug 950242] Include 'username' in VouchedUserProfileAutocomplete.

Comment 10

[William Reynolds [:williamr]]

Verified on stage. From a curated group's admin page, I can add any user to that group. Thanks Dan and Giorgos!

Comment 11

[Justin Crawford [:hoosteeno] [:jcrawford]]

Attachment: management interface in /admin

Admins can now manage group membership from the group's page in /admin. For example, an admin can add and remove members in this group https://mozillians.allizom.org/admin/groups/group/356/. Works like a charm.