950269 - [B2G][NFC] Rename "tech" to "techList" in techDiscovered

Status: RESOLVED FIXED

(Firefox OS Graveyard :: NFC, defect)

Description

[Garner Lee]

Rename the list of NFC techs from "tech" to "techlist" or "techs".

Fix a FIXME in the System App nfc_manager.js. nfc_worker.js sent a techlist as "tech", and nfc_manager will send the entire discovered techlist over to TagDiscovered events if the tag isn't known.

TagDiscovered, is not yet supported, but will be be if NFC tranceive() functionality is added for an unknown tag type.

Comment 1

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

This also needs Gecko modification, adding dependency back on Bug 860906.

Also I purpose to call it 'techList'.

Comment 2

[Garner Lee]

Attachment: Bug 950269: Rename "tech" to "techList" in techDiscovered (Gecko side)

Comment 3

[Garner Lee]

Attachment: Bug 950269: Rename "tech" to "techList" in techDiscovered. (Gaia side) r=alive

Comment 4

[Garner Lee]

Attachment: Bug 950269: Rename "tech" to "techList" in techDiscovered. (Gecko side)

Remove whitespace (nit).

Comment 5

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 8358029 [details] [diff] [review]
Bug 950269: Rename "tech" to "techList" in techDiscovered. (Gecko side)

Review of attachment 8358029 [details] [diff] [review]:
-----------------------------------------------------------------

The patch is okay, but format is not.

Use 8 lines of syntax, and remove the [Patch] in the patch title.

Try
git format-patch -k -U8 parent_commit

Comment 6

[Garner Lee]

Attachment: Bug 950269: Rename "tech" to "techList" in techDiscovered. (Gecko side) r=allstars.chh

Add -U8 param to patch generation.

Comment 7

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Comment on attachment 8358666 [details] [diff] [review]
Bug 950269: Rename "tech" to "techList" in techDiscovered. (Gecko side) r=allstars.chh

Review of attachment 8358666 [details] [diff] [review]:
-----------------------------------------------------------------

Add r=me

Comment 8

[Garner Lee]

In progress try (re-triggering stray failed tests):
https://tbpl.mozilla.org/?tree=Try&rev=6a5f8e12ee59

Comment 9

[Garner Lee]

Alive: check-in needed as well on Gaia side.

Remaining try failure has bug already open it seems: https://bugzilla.mozilla.org/show_bug.cgi?id=951146

Comment 10

[Ryan VanderMeulen [:RyanVM]]

Master: https://github.com/mozilla-b2g/gaia/commit/49469528faecbf3089997bac486a824bcd18dde8

https://hg.mozilla.org/integration/b2g-inbound/rev/bb7f35d963ed

Comment 11

[Garner Lee]

Hi Alive: Gaia: check-in needed.

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/bb7f35d963ed

Comment 13

[Yoshi Cheng-Hao Huang [:allstars.chh][:allstarschh][:yoshi]]

Hi Garner
You forgot replace this line
https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/nfc_manager.js#L370

this._debug('command.tech: ' + command.tech);

Comment 14

[(inactive after 6/18) Alive Kuo [:alive]]

Please file follow up bug.
BTW, I feel that it's time to write unit test for nfc manager.

Comment 15

[Garner Lee]

Yoshi, thanks. I'll open a new bug to fix.

(In reply to Alive Kuo [:alive][NEEDINFO!] from comment #14)
> Please file follow up bug.
> BTW, I feel that it's time to write unit test for nfc manager.

Yes, we've been working without even basic test tool integration since the nfcd swapout. Workweek agenda item?