950307 - [DSDS] Settings: rename sim-manager-outgoing-data-desc

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Francesco Lodolo [:flod]]

> In Settings -> SIM Manager, the strings describing "Data" is to be changed to
> "Data: Internet connection, MMS, A-GPS and Marketplace payments will be sent from"

This string was changed without assigning a new ID to the string, which means localizers and tools will not be aware of the change.

Reviews should keep this principle as a reference: once landed on master, to update a string you need a new ID, unless it's just fixing a typo.
https://developer.mozilla.org/en-US/docs/Making_String_Changes

Comment 1

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Based on https://bugzilla.mozilla.org/show_bug.cgi?id=947432#c11, this bug is used to track the string change for "sim-manager-outgoing-data-desc" on v1.3 and master.

I will create another id in v1.3 for this change and l10n team will notice this, and also, I will update the string directly on master to reflect this change.

Comment 2

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: patch for master

this is patch for master

Comment 3

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: patch for v1.3

this is patch for v1.3

Comment 4

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Hi Arthur,

this is a small patch for l10n change on master and v1.3.

They are just few lines change and please help me review them when you have time ! Thanks :)

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

Thanks for the patch, EJ.

Please uplift the patch to 1.3 manually.

Comment 6

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

(In reply to Arthur Chen [:arthurcc] (PTO 12/25 ~ 1/5) from comment #5)
> Thanks for the patch, EJ.
> 
> Please uplift the patch to 1.3 manually.

OK ! I will wait for 1.3+ flag before merge.

Thanks :P

Comment 7

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

patches were landed on 

gaia/master : 68f7c6a21a4bb037dc53d632654b6fee36793539
gaia/v1.3 : 35a60b82f8cf2d759939a350e2dadbb9d8b2f5dc

Thanks all !

Comment 8

[Axel Hecht [:Pike]]

Can we please back these out?

The real fix is to have the same patch for both master and 1.3, changing the string ID on both. Not just adding a new one like in 1.3, and not doing another non-ID-changing string change like on master.

Comment 9

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

(In reply to Axel Hecht [:Pike] from comment #8)
> Can we please back these out?
> 
> The real fix is to have the same patch for both master and 1.3, changing the
> string ID on both. Not just adding a new one like in 1.3, and not doing
> another non-ID-changing string change like on master.

1. for v1.3, we can't change old strings because they are all frozen and all we can do is add one more string.
2. for master, I don't know why I can't just do a non-id-changing action. 

For branch, it makes sense to add more id changed strings if we need to change the meaning of something. But for master, we have to make the string id to be descriptive with its real meaning instead of making a new one with -1, -2 suffix or any other unrelated naming. Can't l10n team detect this change ?

Comment 10

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

I asked the others about this, I will do some follow-up works for this bug. Thanks.

Comment 11

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

I will update the l10n string on master and leave no changes on v1.3 as described above.

Comment 12

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Backout master related code with commit number : 8cd64d7a7530a8552a07ba959da933c54e363493

Comment 13

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Attachment: patch for master

Arthur, can you take a look of this patch :)? Thanks !!

Comment 14

[Arthur Chen [:arthurcc][inactive after 6/30]]

Comment on attachment 8359111 [details] [review]
patch for master

r=me. Thanks. Please also add a late-l10n keyword.

Comment 15

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

(In reply to Arthur Chen [:arthurcc] from comment #14)
> Comment on attachment 8359111 [details] [review]
> patch for master
> 
> r=me. Thanks. Please also add a late-l10n keyword.

Thanks Arthur, after discussing, there is no need to add late-l10n keyword on master !

Comment 16

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Relanded on Gaia/master : 5ff51693b1e870b3d044c991535c277dc8193651

Thanks all.

Comment 17

[Axel Hecht [:Pike]]

(In reply to EJ Chen [:eragonj] from comment #9)
> (In reply to Axel Hecht [:Pike] from comment #8)
> 
> 1. for v1.3, we can't change old strings because they are all frozen and all
> we can do is add one more string.

String freeze is "we don't change the strings exposed to localizers" as in, at all. That includes not adding new strings. The item of work is frozen. If there are other folks that need to learn this, please spread the news.

Please land the same patch you did on master on 1.3, we're blocked on publishing the latest strings on 1.3 on the broken landing there.

Comment 18

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

(In reply to Axel Hecht [:Pike] from comment #17)
> (In reply to EJ Chen [:eragonj] from comment #9)
> > (In reply to Axel Hecht [:Pike] from comment #8)
> > 
> > 1. for v1.3, we can't change old strings because they are all frozen and all
> > we can do is add one more string.
> 
> String freeze is "we don't change the strings exposed to localizers" as in,
> at all. That includes not adding new strings. The item of work is frozen. If
> there are other folks that need to learn this, please spread the news.
> 

Thanks for sharing this news to me.

> Please land the same patch you did on master on 1.3, we're blocked on
> publishing the latest strings on 1.3 on the broken landing there.

If you checked my PR on v1.3, you will notice that I already did it few weeks ago.

Thanks.

Comment 19

[Axel Hecht [:Pike]]

Sadly, you did not land the same patch on 1.3, and I'm just giving up on getting that fixed now.

Tim, as you know about l10n at mozilla as much as I do, can you go through the various patches in this bug and the upstream bugs, and make sure that there's no remaining uncertainties over what should have happened?

Comment 20

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Pike,

I discussed with EJ offline and it seems there were some misunderstanding on the process. It has been cleared now.

So for this bug, the only difference between v1.3 and master is the unremoved old string at L415
https://github.com/mozilla-b2g/gaia/pull/14871/files#r8924432

Do you still want EJ to fix that in v1.3 branch at this stage? If so he will backout the patch and reland a correct one. Thanks.

Comment 21

[Axel Hecht [:Pike]]

Thanks Tim.

Right now, we have an unused string on 1.3, probably not the only one. Let's let that slip.

Comment 22

[EJ Chen [:eragonj][:小龍哥][Contributor mode on](inactive)]

Thanks Pike & Tim.