950345 - warning in mozilla-central/netwerk/sctp/src/user_recv_thread.c

Status: RESOLVED DUPLICATE of bug 916427

(Core :: Networking, defect)

Description

[Iosif Adrian Mihai]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:18.0) Gecko/20100101 Firefox/18.0 (Beta/Release)
Build ID: 20130201190337

Steps to reproduce:

./mach build


Actual results:

Warning: -Wsign-compare in /home/andu/mozilla/mozilla-central/netwerk/sctp/src/user_recv_thread.c: comparison between signed and unsigned integer expressions
 3:58.43 /home/andu/mozilla/mozilla-central/netwerk/sctp/src/user_recv_thread.c:485:25: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

Comment 1

[Iosif Adrian Mihai]

Attachment: p1.patch

First patch ever
Fixed warning in mozilla-central/netwerk/sctp/src/user_recv_thread.c: comparison between signed and unsigned integer expressions
 3:58.43 /mozilla-central/netwerk/sctp/src/user_recv_thread.c:485:25: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
added explicit cast to int to MLEN

Comment 2

[Iosif Adrian Mihai]

Attachment: Fixes warning; Changed cast to unsigned int.

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Michael: is this fixed by your upstream change as well?

Comment 4

[Michael Tüxen]

The upstream code reads:

	int iovlen = MCLBYTES;
	int want_ext = (iovlen > MLEN)? 1 : 0;

and the patch of yesterday gives you
#define	MLEN		((int)(MSIZE - sizeof(struct m_hdr)))

So there should no patch be necessary anymore.

Short answer: Yes, this is fixed also.