Closed Bug 916427 Opened 7 years ago Closed 6 years ago

Update SCTP from upstream

Categories

(Core :: WebRTC: Networking, defect)

22 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla30

People

(Reporter: jesup, Assigned: jesup)

References

Details

(Whiteboard: [webrtc])

Attachments

(3 files, 2 obsolete files)

Last updated on 3/31/2013 to rev 8441.
Target Milestone: --- → mozilla29
Blocks: 950499
Attached patch moz.build.patchSplinter Review
Attachment #8351577 - Flags: review?(rjesup)
The SCTP stack should be upgraded to rev. 8775 or higher.
Several bugs have been fixed (including memory leaks) and
the support of various platforms has been improved.

Please note that the following files should be removed from
the repo:

netwerk/sctp/src/netinet/sctp_dtrace_declare.h
netwerk/sctp/src/netinet/sctp_dtrace_define.h
netwerk/sctp/src/netinet/sctp_hashdriver.c
netwerk/sctp/src/netinet/sctp_hashdriver.h

Also the patch attached needs to be applied to
netwerk/sctp/src/moz.build

Please let me know of any issues.
Attachment #8351577 - Flags: review?(rjesup) → review+
Duplicate of this bug: 950345
Blocks: 876167
Attachment #8385442 - Flags: review?(tuexen)
Attachment #8385442 - Attachment is obsolete: true
Attachment #8385442 - Flags: review?(tuexen)
Removes the 4 files mentioned earlier, and the SHA1_CTX stuff is no longer needed in the mods patch (just some Android ifdefs)
Attachment #8385441 - Attachment is obsolete: true
Attachment #8388079 - Flags: review?(tuexen)
Comment on attachment 8388080 [details] [diff] [review]
netwerk/sctp/src updated to version 8815 from SVN on Tue Mar 4 2014 rs=jesup

rs=jesup,tuexen
Attachment #8388080 - Flags: review+
Comment on attachment 8388079 [details] [diff] [review]
rollup of modifications (Android) plus restore missing sha1 defines in this version rs=jesup

Review of attachment 8388079 [details] [diff] [review]:
-----------------------------------------------------------------

Please have a look at my comment. Possibly we can minimize the changes...

::: netwerk/sctp/src/user_inpcb.h
@@ +38,5 @@
> +#if defined(ANDROID)
> +#include <arpa/inet.h>
> +#include <netinet/in.h>
> +/* missing defines in Android bionic libc/NDK */
> +typedef uint16_t                in_port_t;

Why is this define needed. In
https://code.google.com/p/sctp-refimpl/source/detail?r=8586
I removed in_port_t from the code.
So can't this change be removed?
Attachment #8388079 - Flags: review?(tuexen) → review+
(In reply to Michael Tüxen from comment #11)
> Comment on attachment 8388079 [details] [diff] [review]
> rollup of modifications (Android) plus restore missing sha1 defines in this
> version rs=jesup
> 
> Review of attachment 8388079 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Please have a look at my comment. Possibly we can minimize the changes...
> 
> ::: netwerk/sctp/src/user_inpcb.h
> @@ +38,5 @@
> > +#if defined(ANDROID)
> > +#include <arpa/inet.h>
> > +#include <netinet/in.h>
> > +/* missing defines in Android bionic libc/NDK */
> > +typedef uint16_t                in_port_t;
> 
> Why is this define needed. In
> https://code.google.com/p/sctp-refimpl/source/detail?r=8586
> I removed in_port_t from the code.
> So can't this change be removed?

I meant typedef instead of define...
Blocks: 984029
No longer blocks: 984029
Blocks: 969715
Blocks: 1139020
Depends on: 984029
You need to log in before you can comment on or make changes to this bug.