916427 - Update SCTP from upstream

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect)

Description

[Randell Jesup [:jesup] (needinfo me)]

Last updated on 3/31/2013 to rev 8441.

Comment 1

[Michael Tüxen]

Attachment: moz.build.patch

Comment 2

[Michael Tüxen]

The SCTP stack should be upgraded to rev. 8775 or higher.
Several bugs have been fixed (including memory leaks) and
the support of various platforms has been improved.

Please note that the following files should be removed from
the repo:

netwerk/sctp/src/netinet/sctp_dtrace_declare.h
netwerk/sctp/src/netinet/sctp_dtrace_define.h
netwerk/sctp/src/netinet/sctp_hashdriver.c
netwerk/sctp/src/netinet/sctp_hashdriver.h

Also the patch attached needs to be applied to
netwerk/sctp/src/moz.build

Please let me know of any issues.

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

Attachment: netwerk/sctp/src updated to version 8815 from SVN on Tue Mar 4 rs=jesup

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

Attachment: rollup of modifications from Mozilla plus fixes for compile problems

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

https://tbpl.mozilla.org/?tree=Try&rev=fe37b93741e1

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

https://tbpl.mozilla.org/?tree=Try&pusher=[e-mail] with the moz.build patch on this bug

Comment 8

[Randell Jesup [:jesup] (needinfo me)]

Attachment: rollup of modifications (Android) plus restore missing sha1 defines in this version rs=jesup

Comment 9

[Randell Jesup [:jesup] (needinfo me)]

Attachment: netwerk/sctp/src updated to version 8815 from SVN on Tue Mar 4 2014 rs=jesup

Removes the 4 files mentioned earlier, and the SHA1_CTX stuff is no longer needed in the mods patch (just some Android ifdefs)

Comment 10

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8388080 [details] [diff] [review]
netwerk/sctp/src updated to version 8815 from SVN on Tue Mar 4 2014 rs=jesup

rs=jesup,tuexen

Comment 11

[Michael Tüxen]

Comment on attachment 8388079 [details] [diff] [review]
rollup of modifications (Android) plus restore missing sha1 defines in this version rs=jesup

Review of attachment 8388079 [details] [diff] [review]:
-----------------------------------------------------------------

Please have a look at my comment. Possibly we can minimize the changes...

::: netwerk/sctp/src/user_inpcb.h
@@ +38,5 @@
> +#if defined(ANDROID)
> +#include <arpa/inet.h>
> +#include <netinet/in.h>
> +/* missing defines in Android bionic libc/NDK */
> +typedef uint16_t                in_port_t;

Why is this define needed. In
https://code.google.com/p/sctp-refimpl/source/detail?r=8586
I removed in_port_t from the code.
So can't this change be removed?

Comment 12

[Michael Tüxen]

(In reply to Michael Tüxen from comment #11)
> Comment on attachment 8388079 [details] [diff] [review]
> rollup of modifications (Android) plus restore missing sha1 defines in this
> version rs=jesup
> 
> Review of attachment 8388079 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> Please have a look at my comment. Possibly we can minimize the changes...
> 
> ::: netwerk/sctp/src/user_inpcb.h
> @@ +38,5 @@
> > +#if defined(ANDROID)
> > +#include <arpa/inet.h>
> > +#include <netinet/in.h>
> > +/* missing defines in Android bionic libc/NDK */
> > +typedef uint16_t                in_port_t;
> 
> Why is this define needed. In
> https://code.google.com/p/sctp-refimpl/source/detail?r=8586
> I removed in_port_t from the code.
> So can't this change be removed?

I meant typedef instead of define...

Comment 13

[Randell Jesup [:jesup] (needinfo me)]

https://tbpl.mozilla.org/?tree=Try&rev=b26bf1c2379a
With the unneeded part removed per the review

https://hg.mozilla.org/integration/mozilla-inbound/rev/de392d555da8
https://hg.mozilla.org/integration/mozilla-inbound/rev/01ca94b4729f

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/de392d555da8
https://hg.mozilla.org/mozilla-central/rev/01ca94b4729f