950368 - Make nsWindowsShellService's WriteBitmap act on a Moz2D SourceSurface instead of a Thebes gfxASurface

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Jonathan Watt [:jwatt]]

As part of converting imgIContainer::GetFrame to return a Moz2D SourceSurface instead of a Thebes gfxASurface, we should nsWindowsShellService's WriteBitmap function act on a Moz2D SourceSurface instead of a Thebes gfxASurface.

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: patch

Not tested yet. May need some tweaks to get the rows and bytes written out in the correct order.

Comment 2

[Jonathan Watt [:jwatt]]

Attachment: patch

I had some trouble with linking, but this works.

Comment 3

[Jonathan Watt [:jwatt]]

Attachment: patch

Comment 4

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8385805 [details] [diff] [review]
patch

Review of attachment 8385805 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/components/shell/src/nsWindowsShellService.cpp
@@ +764,4 @@
>  
> +  RefPtr<DataSourceSurface> dataSurface =
> +    thebesImageSurface->CopyToB8G8R8A8DataSourceSurface();
> +  NS_ENSURE_TRUE(dataSurface, NS_ERROR_FAILURE);

You could use Factory::CreateWrappingDataSourceSurface here instead of making an actual copy. I guess it doesn't matter much if GetFrame is about to change to return a SourceSurface.

Comment 5

[Jonathan Watt [:jwatt]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/fe2afc55a0d1

Comment 6

[Ed Morley [:emorley]]

Backed out for shutdown crashes on B2G:
https://tbpl.mozilla.org/php/getParsedLog.php?id=35665774&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=35665850&tree=Mozilla-Inbound

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/6ae5d97fc882

Comment 7

[Ryan VanderMeulen [:RyanVM]]

This patch wasn't at fault. Re-landed.
https://hg.mozilla.org/integration/mozilla-inbound/rev/012f4e24dba1

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/012f4e24dba1