950499 - Several warnings : comparison between signed and unsigned integer expressions in /mozilla-central/netwerk/sctp/src/user_mbuf.c

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, defect)

Description

[Iosif Adrian Mihai]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:18.0) Gecko/20100101 Firefox/18.0 (Beta/Release)
Build ID: 20130201190337

Steps to reproduce:

./mach build


Actual results:

/mozilla-central/netwerk/sctp/src/user_mbuf.c:726:11: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
/mozilla-central/netwerk/sctp/src/user_mbuf.c:774:10: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
/mozilla-central/netwerk/sctp/src/user_mbuf.c:916:10: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
/mozilla-central/netwerk/sctp/src/user_mbuf.c:1150:15: warning: signed and unsigned type in conditional expression [-Wsign-compare]
/mozilla-central/netwerk/sctp/src/user_mbuf.c:1169:15: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
/mozilla-central/netwerk/sctp/src/user_mbuf.c:1202:11: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
/mozilla-central/netwerk/sctp/src/user_mbuf.c:1205:11: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]

Comment 1

[Iosif Adrian Mihai]

Attachment: fixes warnings described in bug

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8347779 [details] [diff] [review]
fixes warnings described in bug

Review of attachment 8347779 [details] [diff] [review]:
-----------------------------------------------------------------

This wallpapers over the actual problem.  The problem is that this parameter should likely never have been an int, and is so due to history.

Michael: how do you want to go here?  

Iosif: Any changes we make here will want to be upstreamed to the SCTP source we import, so it may make sense to fix it there first and import it.

Comment 3

[Iosif Adrian Mihai]

(In reply to Randell Jesup [:jesup] from comment #2)
> Comment on attachment 8347779 [details] [diff] [review]
> fixes warnings described in bug
> 
> Review of attachment 8347779 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> This wallpapers over the actual problem.  The problem is that this parameter
> should likely never have been an int, and is so due to history.
> 
> Michael: how do you want to go here?  
> 
> Iosif: Any changes we make here will want to be upstreamed to the SCTP
> source we import, so it may make sense to fix it there first and import it.

Could you please give a small hint, if possible, to where the source file where the root of the bug is more precisely? Also, changing the variable in the source file where it was declared would imply changing the parameter list of the function that uses it, right? Have I understood correctly what needs to be done?

Comment 4

[Michael Tüxen]

The code is taken from the FreeBSD kernel, the parameter is of type int.
In the FreeBSD sources the constant MLEN und MHLEN are of type int, see
http://fxr.watson.org/fxr/source/sys/mbuf.h#L64

If have committed an upstream fix, see
http://code.google.com/p/sctp-refimpl/source/detail?r=8768

Thanks for reporting the issue.

Best regards
Michael

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

Iosif: thanks!  So now the problem is fixed upstream due to your report, and will be merged when we next import the sctp library (which should be soon).  

I'll close this out when that lands.

Comment 6

[:Cykesiopka]

Can this bug be closed now that Bug 916427 has landed and stuck?

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

thanks

Comment 8

[Gregory Szorc [:gps]]

https://hg.mozilla.org/projects/metro/rev/a8e3534959ba

Comment 9

[:Cykesiopka]

(In reply to Gregory Szorc [:gps] from comment #8)
> https://hg.mozilla.org/projects/metro/rev/a8e3534959ba

FWIW, this was Bug 1036781 which originally landed with the wrong bug number:
https://hg.mozilla.org/integration/mozilla-inbound/rev/a8e3534959ba
https://hg.mozilla.org/integration/mozilla-inbound/rev/33373d724284
https://hg.mozilla.org/integration/mozilla-inbound/rev/ee2ceee36816