Build accessible/src/windows in unified mode

RESOLVED FIXED in mozilla29

Status

()

Core
Disability Access APIs
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

unspecified
mozilla29
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

4 years ago
Created attachment 8347785 [details] [diff] [review]
Build accessible/src/windows in unified mode
(Assignee)

Updated

4 years ago
Assignee: nobody → ehsan
Blocks: 939583
(Assignee)

Updated

4 years ago
Attachment #8347785 - Flags: review?(surkov.alexander)
Comment on attachment 8347785 [details] [diff] [review]
Build accessible/src/windows in unified mode

>+# These files cannot be built in unified mode because they both include
>+# AccessibleTable2_i.c.

I'm not really sure why that matters, but whatever
Attachment #8347785 - Flags: review?(surkov.alexander) → review+
(Assignee)

Comment 3

4 years ago
(In reply to Trevor Saunders (:tbsaunde) from comment #2)
> Comment on attachment 8347785 [details] [diff] [review]
> Build accessible/src/windows in unified mode
> 
> >+# These files cannot be built in unified mode because they both include
> >+# AccessibleTable2_i.c.
> 
> I'm not really sure why that matters, but whatever

That file is generated by the MSIDL compiler and contains the IID definitions of the interfaces, but it doesn't have include guards, so it cannot be #included more than once in the same translation unit.
https://hg.mozilla.org/mozilla-central/rev/b7a7928b9e5c
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla29
You need to log in before you can comment on or make changes to this bug.